New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fixes #622

Merged
merged 6 commits into from Mar 7, 2018

Conversation

1 participant
@skirpichev
Copy link
Collaborator

skirpichev commented Mar 6, 2018

No description provided.

skirpichev added some commits Mar 5, 2018

polys: be sure that minimal polynomial is irreducible
Helpers for _minpoly_compose() usually assume dom=QQ or
dom=QQ.frac_field(*gens).  So, here we do an attempt to
factorize result if the domain kwarg was provided and
select an appropriate factor.

Thanks to @jksuom who found this issue.

@skirpichev skirpichev added this to the 0.10 milestone Mar 6, 2018

@skirpichev skirpichev force-pushed the skirpichev:misc branch from b5cf4d2 to 04289eb Mar 6, 2018

@skirpichev skirpichev added the domains label Mar 6, 2018

@skirpichev skirpichev force-pushed the skirpichev:misc branch from 7c4e130 to 774fbbf Mar 7, 2018

@skirpichev skirpichev force-pushed the skirpichev:misc branch from 774fbbf to 3767281 Mar 7, 2018

@skirpichev skirpichev merged commit 52eca43 into diofant:master Mar 7, 2018

3 checks passed

codecov/patch 100% of diff hit (target 97%)
Details
codecov/project Absolute coverage decreased by -<1% but relative coverage increased by +3% compared to 51b6759
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@skirpichev skirpichev deleted the skirpichev:misc branch Mar 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment