New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fraction fields in minpoly_groebner() #623

Merged
merged 1 commit into from Mar 9, 2018

Conversation

1 participant
@skirpichev
Copy link
Collaborator

skirpichev commented Mar 8, 2018

No description provided.

@skirpichev skirpichev added this to the 0.10 milestone Mar 8, 2018

@skirpichev skirpichev force-pushed the skirpichev:minpoly-groebner-frac-fields branch 2 times, most recently from d5af645 to 5d705c7 Mar 9, 2018

@skirpichev skirpichev changed the title [wip] Support fraction fields in minpoly_groebner() + misc [wip] Support fraction fields in minpoly_groebner() Mar 9, 2018

Support algebraic function fields in minpoly_groebner()
Argument "domain" added.

Also did some cleanup in minimal_polynomial():

* drop redundant imports
* run _choose_factor here

@skirpichev skirpichev force-pushed the skirpichev:minpoly-groebner-frac-fields branch from 5d705c7 to 1c6482d Mar 9, 2018

@skirpichev skirpichev changed the title [wip] Support fraction fields in minpoly_groebner() Support fraction fields in minpoly_groebner() Mar 9, 2018

@skirpichev skirpichev removed the wrong answer label Mar 9, 2018

@skirpichev skirpichev merged commit 3d43b28 into diofant:master Mar 9, 2018

3 checks passed

codecov/patch 100% of diff hit (target 97%)
Details
codecov/project 96% (+<1%) compared to 61388be
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@skirpichev skirpichev deleted the skirpichev:minpoly-groebner-frac-fields branch Mar 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment