New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify imaginary roots for polys #625

Merged
merged 3 commits into from Aug 13, 2018

Conversation

1 participant
@skirpichev
Copy link
Collaborator

skirpichev commented Mar 10, 2018

  • release notes
  • avoid recomputation
  • more tests?

@skirpichev skirpichev added this to the 0.10 milestone Mar 10, 2018

@skirpichev skirpichev force-pushed the skirpichev:imaginary_roots branch from 0cabdc2 to d97260e Mar 12, 2018

@skirpichev skirpichev force-pushed the skirpichev:imaginary_roots branch 2 times, most recently from 90523e9 to 4fb07f8 Mar 27, 2018

@skirpichev skirpichev force-pushed the skirpichev:imaginary_roots branch from 4fb07f8 to b00b356 Apr 6, 2018

@skirpichev skirpichev force-pushed the skirpichev:imaginary_roots branch from b00b356 to 3963a6c Jun 3, 2018

@skirpichev skirpichev force-pushed the skirpichev:imaginary_roots branch from 3963a6c to f2e03e2 Aug 10, 2018

@skirpichev

This comment has been minimized.

Copy link
Collaborator

skirpichev commented Aug 10, 2018

The sympy code was from sympy/sympy@7b86cb4

@smichr, I believe I have more simple version of your _refine_imaginary() helper. Let me know if you wish review this.

@skirpichev skirpichev force-pushed the skirpichev:imaginary_roots branch from f2e03e2 to 9212086 Aug 11, 2018

@skirpichev skirpichev force-pushed the skirpichev:imaginary_roots branch from 9212086 to 4de4500 Aug 12, 2018

@skirpichev skirpichev changed the title [wip] Identify imaginary roots for polys Identify imaginary roots for polys Aug 12, 2018

@skirpichev skirpichev force-pushed the skirpichev:imaginary_roots branch from 4095b98 to 2683c0a Aug 12, 2018

@skirpichev skirpichev merged commit 13b06b4 into diofant:master Aug 13, 2018

3 checks passed

codecov/patch 100% of diff hit (target 97%)
Details
codecov/project 97% (+<1%) compared to ec7a78e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@skirpichev skirpichev deleted the skirpichev:imaginary_roots branch Aug 13, 2018

skirpichev added a commit to skirpichev/diofant that referenced this pull request Dec 7, 2018

polys: optimize RootOf._eval_conjugate()
After introduction of stable sorting of polynomial roots (diofant#633) and
proper detection of imaginary roots (diofant#625) - it's possible to
apply more efficient method of taking conjugated root for
polynomials with integer coefficients.

skirpichev added a commit to skirpichev/diofant that referenced this pull request Dec 7, 2018

polys: optimize RootOf._eval_conjugate()
After introduction of stable sorting of polynomial roots (diofant#633) and
proper detection of imaginary roots (diofant#625) - it's possible to
apply more efficient method of taking conjugated root for
polynomials with integer coefficients.

This commit also add coverage tests for ComplexInterval.

skirpichev added a commit to skirpichev/diofant that referenced this pull request Dec 7, 2018

polys: optimize RootOf._eval_conjugate()
After introduction of stable sorting of polynomial roots (diofant#633) and
proper detection of imaginary roots (diofant#625) - it's possible to
apply more efficient method of taking conjugated root for
polynomials with integer coefficients.

This commit also add coverage tests for ComplexInterval.

skirpichev added a commit to skirpichev/diofant that referenced this pull request Dec 7, 2018

polys: optimize RootOf._eval_conjugate()
After introduction of stable sorting of polynomial roots (diofant#633) and
proper detection of imaginary roots (diofant#625) - it's possible to
apply more efficient method of taking conjugated root for
polynomials with integer coefficients.

This commit also add coverage tests for ComplexInterval.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment