New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

field_isomorphism*() take fields as arguments #627

Merged
merged 4 commits into from Mar 14, 2018

Conversation

1 participant
@skirpichev
Copy link
Collaborator

skirpichev commented Mar 12, 2018

No description provided.

@skirpichev skirpichev added the polys label Mar 12, 2018

@skirpichev skirpichev added this to the 0.10 milestone Mar 12, 2018

@skirpichev skirpichev force-pushed the skirpichev:drop-an-usage branch from b37bef9 to 57f149a Mar 12, 2018

skirpichev added some commits Mar 11, 2018

polys: remove usage of AlgebraicNumber from the codebase
These are last important places, where this class was used.

Following backward-incompatible changes introduced:
  1. field_isomorphism*() functions take fields as arguments
  2. to_number_field() returns field element

@skirpichev skirpichev force-pushed the skirpichev:drop-an-usage branch from 57f149a to 8dc98f1 Mar 12, 2018

@skirpichev skirpichev force-pushed the skirpichev:drop-an-usage branch from 22a7b2e to 1adb578 Mar 13, 2018

@skirpichev skirpichev changed the title [wip] field_isomorphism*() take fields as arguments field_isomorphism*() take fields as arguments Mar 13, 2018

@skirpichev skirpichev merged commit 09a99f5 into diofant:master Mar 14, 2018

3 checks passed

codecov/patch 100% of diff hit (target 97%)
Details
codecov/project 96% (+<1%) compared to 08420cc
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@skirpichev skirpichev deleted the skirpichev:drop-an-usage branch Mar 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment