Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Misc fixes #654
3 times, most recently
Jun 23, 2018
Jun 24, 2018
@asmeurer, I don't think 4030e3d should go in sympy, but Rational.p/q properties looks too cryptic. Why not provide numerator/denominator properties? This would make Rational and Integer types more compatible with python numbers hierarchy. (In fact, Rational class probably will be fully compatible after this.)
I agree it should support the ABCs. It looks like there's an open issue for it sympy/sympy#12134. The
@asmeurer, people can think that attribute is private if it name starts with underscore. That's not just a widely adopted convention, Python import system has some additional support for this.
But people can't guess that attribute is private, if its naming doesn't suggest that. And they will use this, for sure, e.g. see here.
Easy to fix? Oh, I don't think so, given you have ">>" for Implies and so on.