New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fixes #659

Merged
merged 6 commits into from Jul 16, 2018

Conversation

1 participant
@skirpichev
Collaborator

skirpichev commented Jul 16, 2018

No description provided.

@skirpichev skirpichev added this to the 0.10 milestone Jul 16, 2018

@skirpichev skirpichev changed the title [wip] Misc fixes Misc fixes Jul 16, 2018

polys: more simple construction of algebraic integers in primitive_el…
…ement()

Original version, from removed code in AlgebraicNumber.to_algebraic_integer(),
see cb6e730.  This produce more complex elements in simple cases:

    In [1]: QQ.algebraic_field(sqrt(2)/3)
    Out[1]: QQ<3*sqrt(2)>

but will work for algebraic domains too.

    In [2]: QQ.algebraic_field(sqrt(2)).algebraic_field(sqrt(3)/5)
    Out[2]: QQ<sqrt(2)><5*sqrt(3)>

@skirpichev skirpichev force-pushed the skirpichev:misc branch from c0b101a to c1cd5cf Jul 16, 2018

@skirpichev skirpichev merged commit 934926c into diofant:master Jul 16, 2018

3 checks passed

codecov/patch 100% of diff hit (target 97%)
Details
codecov/project 96% (+<1%) compared to 8c7959e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@skirpichev skirpichev deleted the skirpichev:misc branch Jul 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment