New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Subs interface #667

Merged
merged 1 commit into from Aug 3, 2018

Conversation

1 participant
@skirpichev
Copy link
Collaborator

skirpichev commented Aug 1, 2018

Like sympy/sympy#2613.

In this way, Subs will be more consistent with subs method, which take two scalar argument or one iterable container of pairs.

  • rebase, commit msg
  • release notes
  • keep Subs(expr, sym, var) "scalar" syntax?

@skirpichev skirpichev added this to the 0.10 milestone Aug 1, 2018

Change Subs interface to be more consistent with .subs method
Later takes (1) two scalar argument or (2) an iterable container of
pairs.  We will do (2) assumption for *args of Subs class.

See also sympy/sympy#2613, where similar convention was
adopted for Order.

@skirpichev skirpichev force-pushed the skirpichev:subs-interface branch from b7e5624 to b98bac6 Aug 2, 2018

@skirpichev skirpichev changed the title [wip] Change Subs interface Change Subs interface Aug 2, 2018

@skirpichev skirpichev merged commit 5d72cf5 into diofant:master Aug 3, 2018

3 checks passed

codecov/patch 100% of diff hit (target 97%)
Details
codecov/project 96% (+<1%) compared to 950873d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@skirpichev skirpichev deleted the skirpichev:subs-interface branch Aug 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment