New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed SubsSet in gruntz, use xreplace() #68

Merged
merged 2 commits into from May 3, 2015

Conversation

1 participant
@skirpichev
Copy link
Collaborator

skirpichev commented Apr 22, 2015

  • rebase (squash commits with fixed tests)
  • benchmark (slightly better)
  • better commit msgs, add refs to sympy/sympy#236
  • cleanup gruntz tests (merge some functions, remove XPASSed tests, etc)
  • add test for #56
  • simplify sort_key
  • better docstrings in gruntz, add examples
  • rename sign? limitsign? singinf? // separate commit
  • use evaluate context manager (without touching xreplace): revert or fix lru_cache stuff

@skirpichev skirpichev changed the title Removed SubsSet in gruntz, use subs() Removed SubsSet in gruntz, use xreplace() Apr 25, 2015

@skirpichev skirpichev force-pushed the gruntz-use-subs branch 3 times, most recently from 78df9da to 4060a66 Apr 26, 2015

@skirpichev skirpichev added the bug label May 2, 2015

@skirpichev skirpichev force-pushed the gruntz-use-subs branch 2 times, most recently from 138dfdc to c4136ab May 3, 2015

skirpichev added some commits Apr 26, 2015

Removed SubsSet in gruntz, use xreplace
This reverts de0ede9 (see sympy/sympy#236).
Module code now much more clean.  This also fix example 3.27 from
Gruntz, p. 56, mrv example 3.21, p. 47 (expected value was fixed to
match the thesis text) and tests in test_gruntz_evaluation_slow().

Also, closes #56

Note: 1) rewrite() functions has new signature, tests fixed.
      2) mrv() accepts only Pow instances like f(x)^n, one test adapted.

Kids, don't break this code again!  Please.
Removed special case for factorial in limit()
The test_factorial() was slightly adapted, because now we have
gamma functions in the output.  See TODO in limitinf about final
rewrite('intractable').

Also, during limit calculations, replace z with Dummy
symbol, if limit point z0 has z as a subexpression.

@skirpichev skirpichev force-pushed the gruntz-use-subs branch from c4136ab to 9bc4f24 May 3, 2015

skirpichev added a commit that referenced this pull request May 3, 2015

Merge pull request #68 from skirpichev/gruntz-use-subs
Removed SubsSet in gruntz, use xreplace()

@skirpichev skirpichev merged commit 94e3e73 into master May 3, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 92.06%
Details

@skirpichev skirpichev deleted the gruntz-use-subs branch May 3, 2015

@skirpichev skirpichev modified the milestone: 0.8.0 Sep 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment