New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use modular exponentiation with RootOf #691

Merged
merged 2 commits into from Oct 20, 2018

Conversation

1 participant
@skirpichev
Copy link
Collaborator

skirpichev commented Oct 12, 2018

No description provided.

@skirpichev skirpichev added this to the 0.10 milestone Oct 12, 2018

@skirpichev skirpichev changed the title Use modular exponentiation with RootOf [wip] Use modular exponentiation with RootOf Oct 13, 2018

@skirpichev skirpichev force-pushed the skirpichev:rootof-pow branch from 78a782d to 831dc5c Oct 18, 2018

skirpichev added some commits Oct 12, 2018

Use modular exponentiation for RootOf with integer exponents
This is a variant of initial version of sympy/sympy#8552,
proposed by @cswiercz.

More enhanced simplification, e.g. removing RootOf's from the
denominator - probably should go to a dedicated function.
Maybe radsimp() should be reimplemented.

Closes sympy/sympy#8543

@skirpichev skirpichev force-pushed the skirpichev:rootof-pow branch from 8083a7f to 7d31c7b Oct 19, 2018

@skirpichev skirpichev changed the title [wip] Use modular exponentiation with RootOf Use modular exponentiation with RootOf Oct 19, 2018

@skirpichev skirpichev merged commit 5c79a0f into diofant:master Oct 20, 2018

3 checks passed

codecov/patch 100% of diff hit (target 97%)
Details
codecov/project 97% (+<1%) compared to b710b86
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@skirpichev skirpichev deleted the skirpichev:rootof-pow branch Oct 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment