New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dmp ext factor() for multivariate case #717

merged 16 commits into from Nov 17, 2018


1 participant

skirpichev commented Nov 15, 2018

An alternative to 619787b. This pull request includes also some factorization module refactoring and dup_ext_factor() removal.

skirpichev added some commits Nov 14, 2018

Fix dmp_ext_factor() for multivariate case
dmp_sqf_part() return part of the input, which is square-free
wrt to the first variable.  Constant factors (wrt to this variable),
which goes to the content part, are omitted.  Hence, these
recursive calls to the dmp_ext_factor().

@skirpichev skirpichev force-pushed the skirpichev:fix-dmp_ext_factor branch from fdc8e01 to 45cd114 Nov 17, 2018

@skirpichev skirpichev merged commit 83410ff into diofant:master Nov 17, 2018

3 checks passed

codecov/patch 100% of diff hit (target 97%)
codecov/project 97% (+<1%) compared to a921f28
continuous-integration/travis-ci/pr The Travis CI build passed

@skirpichev skirpichev deleted the skirpichev:fix-dmp_ext_factor branch Nov 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment