New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #714 (v3) #726

Merged
merged 9 commits into from Dec 6, 2018

Conversation

1 participant
@skirpichev
Collaborator

skirpichev commented Dec 3, 2018

  • documentation (mention Yun algorithm)
  • release notes?
  • remove gf_sqf_p()?

@skirpichev skirpichev added this to the 0.10 milestone Dec 3, 2018

@skirpichev skirpichev changed the title [wip] Fix #714 (v2) [wip] Fix #714 (v3) Dec 5, 2018

@skirpichev skirpichev referenced this pull request Dec 5, 2018

Closed

Fix #714 #719

6 of 9 tasks complete

@skirpichev skirpichev force-pushed the skirpichev:fix-714-v3 branch 2 times, most recently from a6d4a57 to 9dc614a Dec 5, 2018

@skirpichev skirpichev changed the title [wip] Fix #714 (v3) Fix #714 (v3) Dec 5, 2018

skirpichev added some commits Dec 5, 2018

polys: revert dmp_ext_factor()
To version 429b0ee (except dmp_factor_list_include()
changes).  Try to adapt dmp_sqf_* functions instead.
polys: correct dmp_sqf_p/dmp_sqf_part() functions
These now test/return square-free part wrt to all variables.

dmp_sqf_p() was exported in high-level polys interfaces and used
by PolyElement class.

See #714
polys: sqf_norm() should be square-free wrt all variables
dmp_ext_factor() was adapted to revert all shifts (vector [s]*(u+1)).
polys: fix dmp_sqf_list() to make full sqf decomposition
This finally closes #714.  Now function return square-free
decomposition wrt to all variables.  Like other dmp_sqf_*() functions.
polys: standartize dmp_sqf_*() tests
Use dmp_sqf_*() for doctests and PolyElement interfaces
for regular tests.

@skirpichev skirpichev force-pushed the skirpichev:fix-714-v3 branch 2 times, most recently from c9bd918 to 52d0741 Dec 6, 2018

@skirpichev skirpichev merged commit 577c2fd into diofant:master Dec 6, 2018

3 checks passed

codecov/patch 100% of diff hit (target 97%)
Details
codecov/project Absolute coverage decreased by -<1% but relative coverage increased by +2% compared to 2e1634c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@skirpichev skirpichev deleted the skirpichev:fix-714-v3 branch Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment