New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fixes #729

merged 5 commits into from Dec 5, 2018


1 participant
Copy link

skirpichev commented Dec 5, 2018

@skirpichev skirpichev added this to the 0.10 milestone Dec 5, 2018

skirpichev added some commits Dec 5, 2018

polys: more test to ensure coverage of modgcd()
Also, reorder some statements to workaround peephole
optimization issue, see
polys: removed inaccessible case in integer_rational_reconstruction()
See also: P. S. Wang, M. J. T. Guy, and J. H. Davenport, p-adic
reconstruction of rational numbers, SIGSAM Bulletin 16 (1982).
polys: improve test coverage for
Here we take into account, that primitive_element()
return a monic polynomial (see 5347365).

@skirpichev skirpichev changed the title domains: Replace has_Field/Ring with is_Field/Ring Misc fixes Dec 5, 2018

@skirpichev skirpichev merged commit 2e1634c into diofant:master Dec 5, 2018

3 checks passed

codecov/patch 100% of diff hit (target 97%)
codecov/project 97% (+<1%) compared to 62dc7a8
continuous-integration/travis-ci/pr The Travis CI build passed

@skirpichev skirpichev deleted the skirpichev:domains-is-ring-field branch Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment