New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize RootOf's caching #741

Merged
merged 3 commits into from Dec 27, 2018

Conversation

1 participant
@skirpichev
Copy link
Collaborator

skirpichev commented Dec 21, 2018

  • ensure to re-enable testing on py3.6

@skirpichev skirpichev added this to the 0.10 milestone Dec 21, 2018

@skirpichev skirpichev force-pushed the skirpichev:fix-723 branch 2 times, most recently from a474417 to bb50229 Dec 26, 2018

skirpichev added some commits Dec 26, 2018

polys: improve caching of RootOf
Be sure cache insertion happens only after sorting and
abort one in case of cache hit for square-free polynomial.

Fix for polynomials which are not square-free will require major
redisign of caching, so make this step first.

Closes #723

@skirpichev skirpichev added testing and removed wrong answer labels Dec 27, 2018

@skirpichev skirpichev force-pushed the skirpichev:fix-723 branch from 27e8de3 to cadf77f Dec 27, 2018

@skirpichev skirpichev changed the title [wip] Optimize RootOf's caching Optimize RootOf's caching Dec 27, 2018

@skirpichev skirpichev merged commit 65bf0fd into diofant:master Dec 27, 2018

3 checks passed

codecov/patch 100% of diff hit (target 97%)
Details
codecov/project 97% (+<1%) compared to 32e9af8
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@skirpichev skirpichev deleted the skirpichev:fix-723 branch Dec 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment