Update the specs and add failures for some use-cases #38

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
@heeton

heeton commented Jul 13, 2012

I've updated the specs a bit to try and work out what the expectations are for this gem.

@tomtaylor - I've included your specs

@eshear - I've included your specs

I've also added a few things:

  1. Should we be raising a warning when we try to use symbol-keys? HStore doesn't support these, so either we warn that we are converting them to strings, or we store them as ":symbol" or something so they can be converted back.
  2. What should we be doing with literals? Should {a: true} come out as {a: "true"} ?
  3. Should we allow nil keys?

I guess this all boils down to: Should we be making sure that any hash going into hstore is always identical to the one that will come out of it?

Please comment on the new spec file, and once we've come to some agreement I'll try and implement everything needed.

@diogob

This comment has been minimized.

Show comment Hide comment
@diogob

diogob Sep 14, 2012

Owner

Sorry for the delay to integrate, I'm taking a look at the patch right now

Owner

diogob commented Sep 14, 2012

Sorry for the delay to integrate, I'm taking a look at the patch right now

@diogob diogob closed this Feb 4, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment