Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OLD-7027: Same as billing checkbox not updating correctly #33

Closed
cpaschen opened this issue Oct 13, 2012 · 0 comments
Closed

OLD-7027: Same as billing checkbox not updating correctly #33

cpaschen opened this issue Oct 13, 2012 · 0 comments
Assignees

Comments

@cpaschen
Copy link
Member

Description

When the user UNCHECKS the 'same as billing' the script is still using the billing address (and not the shipping address).

Tested and it's using the billing address to determine if there is a valid shipping method AND storing the Billing address as the shipping address.

Tested on 0.9.0 AND the latest trunk.

History

Updated by Chris DioscouriChris Paschen. 5 months ago

Status changed from Needs Testing to Requires Feedback
Assignee changed from Chris DioscouriChris Paschen. to Lukas Polak

It looks like it's ALMOST working now;
However, when you UNCHECK the 'same as billing' box, I think it should trigger the ajax verification at that point.
This is because IF I just UNCHECK that box, the shipping options don't update (i.e. when you first uncheck the box there is no shipping address - so the 'select a shipping method' area should show 'no shipping options available'.
But now they don't. I can now go on and click the 'continue' button. {Yes, it does perform a final data check there, but it would make more sense in the workflow for users to check it when you actually change that box - which should be changing the 'state' of the order from 'same address' to 'different address'.)

And if I un-check the box, start to fill in the form, then re-check the box (to go back to using 'same as billing') it doesn't update the shipping availability,etc.

If this is a minor change I think we should make it for this next release.

#1 Updated by Lukas Polak 5 months ago

Status changed from New to Needs Testing
Assignee changed from Lukas Polak to Chris DioscouriChris Paschen.
% Done changed from 0 to 100
Resolution set to Fixed
Documentation Status set to Unnecessary
Update Log time Watch Copy Delete

Associated Revisions

Revision 2570

Added by Lukas Polak 5 months ago

fixed problem with shipping address when "same as billing" is unchecked in OPC - refs #7027

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants