Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OLD-6913: Impossible edit addressed w/o address name #50

Closed
cpaschen opened this issue Oct 20, 2012 · 0 comments
Closed

OLD-6913: Impossible edit addressed w/o address name #50

cpaschen opened this issue Oct 20, 2012 · 0 comments

Comments

@cpaschen
Copy link
Member

Description

if "Show Address Name Field" is setted OFF, then the address will be inserted in table without Name.

If an address hasn't a name, customer can't modify it in "Manage Your Addresses"

this problem is not present during OPC, in OPC you see address_id as a name.
I used this trick as starting point e to fix this bug in "Manage Your Addresses"

bug fix is attachment file

edit_addresses_wo_name.patch (723 Bytes) Alessandro Manfré, 04/05/2012 01:29 am

History

Updated by Mikael Colboc 6 months ago

Not only it can not be edited by customer, but trying to delete it fails with error: COM_TIENDA_UNABLE_TO_CHANGE: # (address_id)

I think a automatic name like "Default #" should be set whenever an address is saved and its title field is empty, without adding any extra checkbox.
Because if you display the address title field, but do not validate it, the customer can leave it empty and the same problem happens.

#1 Updated by Chris DioscouriChris Paschen. 7 months ago

Category set to Admin - Configuration
Status changed from New to Requires Feedback
Assignee changed from Chris DioscouriChris Paschen. to Lukas Polak
Target version set to Version 0.9.2 - POS Finalization

Actually, I'm not sure that we want to do it this way - this 'covers up' a missing field/data.

I think it would be better to add a feature on the admin-side (under the 'show/hide' address name) that IF a user turns off the display of the address name field that there is a checkbox that can be set in config to 'Automatically name the address entry using generated name' ... and then just insert 'Default' as the address name.

Lukas - what do you think about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants