Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make validator offline version working (Currently, validator.js is fetched over the network when extension is activated) #12

Open
dparikh opened this issue Aug 17, 2018 · 0 comments

Comments

@dparikh
Copy link
Contributor

commented Aug 17, 2018

Currently, the AMP HTML Validator (https://www.npmjs.com/package/amphtml-validator)
fetches the latest version of validator.js from the CDN (https://cdn.ampproject.org/v0/validator.js).

If not connected to the internet, this extension should still use the embedded version of validator.js and only use the CDN version when connected.
Notify user either by an InformationMessage or by console or status bar that offline version (which may not be the most recent one) is being used.

Also, figure out a way to periodically update the extension to include the most recent validator.js version for offline usage.

Updating the dependency of amphtml-validator NPM package is just not enough since the amphtml-validator package only gets the new version in NPM when API changes but the engine code validator.js (https://github.com/ampproject/amphtml/blob/master/validator/engine/validator.js) gets regular patches.

@dparikh dparikh added the enhancement label Aug 17, 2018

@dparikh dparikh added this to the Release 0.0.2 milestone Aug 17, 2018

@dparikh dparikh self-assigned this Aug 17, 2018

@dparikh dparikh changed the title Make offline version working Make validator offline version working (Currently, validator.js is fetched when extension is activated) Aug 17, 2018

@dparikh dparikh changed the title Make validator offline version working (Currently, validator.js is fetched when extension is activated) Make validator offline version working (Currently, validator.js is fetched over the network when extension is activated) Aug 17, 2018

@dparikh dparikh modified the milestones: Release 0.0.2, Release 0.0.3 Aug 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.