Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable settings in extension #13

Open
dparikh opened this issue Aug 17, 2018 · 0 comments
Open

Enable settings in extension #13

dparikh opened this issue Aug 17, 2018 · 0 comments
Assignees
Labels
question
Milestone

Comments

@dparikh
Copy link
Contributor

dparikh commented Aug 17, 2018

The following 2 configuration settings are planned but not implemented:

Enable/Disable AMP HTML validation without uninstall/disable
"amphtml.validator.enabled": true|false // Default: true

Keep/Remove AMP HTML validation errors after closing the document
"amphtml.validator.keepIssuesAfterDocumentClose": false //Default:true


The issue is how the VS Code fires onDidChangeContent() and onDidClose() events when user clicks away from PROBLEMS panel and activates again PROBLEMS panel. (Reported in latest VS Code version 1.26.0). Due to this issue, the document is re-validated every time user focuses back to PROBLEMS panel.

Debug or create a bug on VS Code to figure out why and how to resolve this.

Ref: #8

@dparikh dparikh added the question label Aug 17, 2018
@dparikh dparikh added this to the Release 0.0.3 milestone Aug 17, 2018
@dparikh dparikh self-assigned this Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question
Projects
None yet
Development

No branches or pull requests

1 participant