Colorfa #128
Merged
Colorfa #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Parameters | ||
| ---------- | ||
| FA : array-like | ||
| 3D array of the fractional anisotropy |
There was a problem hiding this comment.
This can also be 1D and 2D, as your tests show
There was a problem hiding this comment.
The description was updated accordingly.
|
typically we use lower case variable names per pep-8, http://www.python.org/dev/peps/pep-0008/ On a related note, the script dipy/bin/fit_tensor will compute and save a color fa map as a nifti_file so that it can be opened using visualization software, for example trackvis. This function looks useful separate from that functionality, but I thought I would bring it up so everyone was aware of it. |
Added a test to check if fa and evecs shape are matching and if the two last dimensions of evecs are (3,3). Now following pep-8 regarding lower case variables names.
|
Looks good Sam. I 'll use it for an example shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a function that computes the RGB/ColorFA when supplied with a list of eigen vectors and the FA. There are also some tests for the 1D, 2D and 3D cases.