Flow csd sh order #1669
Merged
Flow csd sh order #1669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arokem
commented
Nov 26, 2018
| # Test that the number of coefficients is what you would expect | ||
| # given the order of the sh basis: | ||
| assert_equal(shm_data.shape[-1], | ||
| sph_harm_ind_list(sh_order)[0].shape[0]) |
There was a problem hiding this comment.
This is where I test that the shape of the output conforms with the input sh_order provided.
Codecov Report
@@ Coverage Diff @@
## master #1669 +/- ##
=========================================
Coverage ? 88.49%
=========================================
Files ? 233
Lines ? 29283
Branches ? 3223
=========================================
Hits ? 25914
Misses ? 2699
Partials ? 670
Continue to review full report at Codecov.
|
|
LGTM, Thanks for this fix @arokem! I will merge it this evening |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In using the CSD workflow, I discovered that changing the
sh_orderinput parameter doesn't seem to do anything. Tracking this down in the code, I see that it was hard-coded assh_order = 8. This PR changes that and also adds some testing around that. It also more flexibly checks the inputs, so that we are not making assumptions about the input data.