BUG: Fix blank image being recorded at linear_fascicle_evaluation.py.
#1703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kesshijordan Please review. |
|
A few thoughts:
|
|
The reported test failure is related to #1698. |
|
Thank you for this @jhlegarreta. LGTM, I made this correction before generating the documentation and it works correctly. It can be merged after #1698 |
Fix blank image being recorded at `linear_fascicle_evaluation.py`: provide the `fury.window.record` method with the rendered scene. Fixes dipy#1633.
jhlegarreta
force-pushed
the
FixBlankImageRecordedLinearFascicleEvaluationExample
branch
from
231d036
to
309c995
Compare
Codecov Report
@@ Coverage Diff @@
## master #1703 +/- ##
==========================================
+ Coverage 84.26% 84.27% +<.01%
==========================================
Files 114 114
Lines 13556 13556
Branches 2139 2139
==========================================
+ Hits 11423 11424 +1
Misses 1637 1637
+ Partials 496 495 -1
|
jhlegarreta
deleted the
FixBlankImageRecordedLinearFascicleEvaluationExample
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix blank image being recorded at
linear_fascicle_evaluation.py:provide the
fury.window.recordmethod with the rendered scene.Fixes #1633.