Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Horizon Tabs #2744

Merged
merged 136 commits into from Apr 21, 2023
Merged

Horizon Tabs #2744

merged 136 commits into from Apr 21, 2023

Conversation

guaje
Copy link
Contributor

@guaje guaje commented Mar 10, 2023

This PR replaces Horizon's panels with a tab system and introduces a new API to add custom tabs to Horizon.

@guaje
Decoupled image slicer panel from peak panel.
861e51a
@guaje
Decoupled peak from image slicer. Added pam validation. Added new pea…
82d0b52 
…k actor.
@guaje
Added horizon module in viz module.
b179915
@guaje
Moved tab.py.
cbf9173
@guaje
Renamed tab.py as base.py. Added tab file for peak data.
48ff63d
@guaje
Renamed tabs module as tab.
ff271fd
@guaje
Added peaks tab functionality.
676fdc2
@guaje
Added build function to handle initialization.
65fc6a4
@guaje
Added classes reindexing at the tab module level.
d15cf70
@guaje
Refactored private functions. Refactored concrete methods in PeakTab …
80fca7c 
…class.
@guaje
Added abstract HorizonTab class.
458d1fa
@guaje
Indexed HorizonTab class in tab module.
fe59d15
@guaje
PeaksTab now inherits from HorizonTab.
6d02bfd
@guaje
Added tab_ui property and tabs initialization to TabManager.
998c34b
@guaje
Added tab manager to app.
b0e8b12
@guaje
Fixed abstract method and property conflict.
aedb9c4
@guaje
Tab repositioning.
df8afa7
@guaje
Minor fixes in peak tab.
7143cfd
@guaje
Added build_label utility function.
da4e5d1
@guaje
Added color_slider utility function.
bc11911
@guaje
Minor changes in utility functions.
48bc2e9
@guaje
Resized show manager. Forwarded window size to TabManager.
2df5e0f
@guaje
Computed tab size and position from window size.
552fec6
@guaje
Added panel in PeakTab.
4025018
@guaje
Adjusted PeakTab's panel look and feel.
5fe105c
@guaje
Added RoIsTab.
ef03157
@guaje
Indexed RoIsTab.
b881904
@guaje
Added RoIsTab to build_show function. Changed behavior of RoI contour…
8b15cb9 
… actors.
@guaje
Removed unused import in roi.py.
8f72baa
@guaje
Minor aesthetic changes in RoIsTab.
893849d
guaje added 18 commits April 20, 2023 13:47
@guaje
Refactored key_press as a private class method. Refactored show_all a…
137f0c8 
…s a private class method.
@guaje
Disabled picking feedback. Fix in another PR.
6d01e30
@guaje
Fixed percentileofscore calculations.
d6e77d0
@guaje
Added tractogram_clusters property to ClustersVisualizer.
9bd2809
@guaje
Fixed key_events show_all, expand, hide, invert, reset, and new_window.
670df40
@guaje
Fixed save key_press event.
01372bd
@guaje
Minor changes in Slices Tab and Visualizer.
5a1330f
@guaje
Added TabUI repositioning based on window size changes.
4c7d162
@guaje
Fixed help panel repositioning.
57f3b54
@guaje
Improved key_press_event 'o', now it's a toggle button.
95708b5
@guaje
Fixed show_all function.
65bc03c
@guaje
Fixed help panel repositioning based on status.
0f7e9dd
@guaje
Revised hide fucntion.
05d67ea
@guaje
Revised invert function.
86ee72e
@guaje
Revised reset function.
81cecee
@guaje
Added 'o' label in help menu.
4317169
@guaje
Changed font size in tab bar items. Added space.
2897c16
@guaje
Removed right click option from help menu.
cf75f25
@Garyfallidis Garyfallidis changed the title [WIP]: Horizon Tabs Horizon Tabs Apr 21, 2023
@guaje guaje marked this pull request as ready for review April 21, 2023 00:06
@Garyfallidis
Copy link
Contributor

Congrats @guaje!

@Garyfallidis Garyfallidis merged commit 570b36b into dipy:master Apr 21, 2023
24 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@guaje @Garyfallidis