Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: move script running code into own module #418

Merged
merged 3 commits into from Oct 7, 2014

Conversation

matthew-brett
Copy link
Contributor

Refactor code to run scripts into own module. In fact I'm using a version I
refactored for another project, to make it easier to use across projects, but
I think this makes the code easier to read and support.

Refactor code to run scripts into own module.  In fact I'm using a
version I refactored for another project, to make it easier to use
across projects, but I think this makes the code easier to read and
support.
Python 3.2 does not set __package__; work around for now.
I tend to think of directories nearer root as being 'down', it looks
more common to think of this as being 'up', change according to Ariel's
suggestion.
@arokem
Copy link
Contributor

arokem commented Sep 25, 2014

Cool. Did you decide against the Travis reorg? For future reference, is this the relevant commit on nipy?

nipy/nipy@53e0fdf

@matthew-brett
Copy link
Contributor Author

I thought I would work round the problem for now.

Here's my WIP for moving to the more standard build system: #428

@arokem
Copy link
Contributor

arokem commented Oct 1, 2014

Cool. How about we hold off on this, until we resolve the Travis stuff?
Hopefully fast - I will take a look now.

On Wed, Oct 1, 2014 at 9:09 AM, Matthew Brett notifications@github.com
wrote:

I thought I would work round the problem for now.

Here's my WIP for moving to the more standard build system: #428
#428


Reply to this email directly or view it on GitHub
#418 (comment).

@arokem
Copy link
Contributor

arokem commented Oct 6, 2014

OK - seems like we will need this anyway, considering that we might keep supporting 3.2, so I am going to go ahead and merge this.

@matthew-brett
Copy link
Contributor Author

Thanks for the review...

On 10/6/14, Ariel Rokem notifications@github.com wrote:

OK - seems like we will need this anyway, considering that we might keep
supporting 3.2, so I am going to go ahead and merge this.


Reply to this email directly or view it on GitHub:
#418 (comment)

arokem added a commit that referenced this pull request Oct 7, 2014
RF: move script running code into own module
@arokem arokem merged commit e6daa20 into dipy:master Oct 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants