New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Upcoming] Release 1.5.0 #2462
[Upcoming] Release 1.5.0 #2462
Conversation
Looks like #2461 would be a quick fix. Should we add that to this release? |
yes, added. #2463 also |
e615c8d
to
d6bccd3
Compare
I think we are ready for the Release. If I find time, I will look #2369 but it should not block the release. Also, we need to check documentation generation and if there is no surprise with the wheels. |
Codecov Report
@@ Coverage Diff @@
## master #2462 +/- ##
=======================================
Coverage 85.08% 85.08%
=======================================
Files 129 129
Lines 17579 17579
Branches 2994 2994
=======================================
Hits 14957 14957
Misses 1926 1926
Partials 696 696 |
As you can see here, the wheels for manyLinux python 3.10 are failing. If someone has any idea on how to fix that. I will appreciate it a lot the help! |
Sorry: this is above my head. |
The error is https://github.com/MacPython/numpy-wheels I would look to see how they have updated to get 3.10 working... |
Thank you for looking into this @larsoner.
yes, we are using this in one matrix.
Another matrix use this one as you can see here but it fails also with the following error: ERROR: Exception:
Traceback (most recent call last):
File "/venv/lib/python3.10/site-packages/pip/_internal/cli/base_command.py", line 173, in _main
status = self.run(options, args)
File "/venv/lib/python3.10/site-packages/pip/_internal/cli/req_command.py", line 203, in wrapper
return func(self, options, args)
File "/venv/lib/python3.10/site-packages/pip/_internal/commands/install.py", line 390, in run
installed = install_given_reqs(
File "/venv/lib/python3.10/site-packages/pip/_internal/req/__init__.py", line 73, in install_given_reqs
requirement.install(
File "/venv/lib/python3.10/site-packages/pip/_internal/req/req_install.py", line 723, in install
scheme = get_scheme(
File "/venv/lib/python3.10/site-packages/pip/_internal/locations/__init__.py", line 155, in get_scheme
new = _sysconfig.get_scheme(
File "/venv/lib/python3.10/site-packages/pip/_internal/locations/_sysconfig.py", line 131, in get_scheme
scheme_name = _infer_prefix()
File "/venv/lib/python3.10/site-packages/pip/_internal/locations/_sysconfig.py", line 45, in _infer_prefix
return sysconfig.get_preferred_scheme("prefix") # type: ignore
AttributeError: module 'sysconfig' has no attribute 'get_preferred_scheme' I suppose, the VM needs a more recent version of pip. I just do not know how to update it.
I will experiment with a newer one. Also, it seems that Numpy migrates to cibuildwheel for building Linux and macOS wheels as you can see here We might do the same move. I will experiment that this morning. |
ok, manylinux1 has been dropped for python3.10, makes sense now. More info on pypa/manylinux#994 |
ok, all good with python3.10 and manylinux2014. I will explore cibuildwheel another day. Finalizing doc generation, checking tutorials and examples. |
a4f2c03
to
495cbe7
Compare
LGTM! Ready to go, I believe. 🚀 ❗ ❗ ❗ ⚡ |
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Release time! Let's GO! 💯 |
Preparation for 1.5.0 release, targeting
November 7th-8thMarch 1st.Desired PR (need review / feedback / update)
There is room for the following PR to be finished and merge
Most of them can be done on time, I think 😄
Please comment to flag any other issues or PR that should be addressed for this release
Release checklist