Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Upcoming] Release 1.5.0 #2462

Merged
merged 9 commits into from Mar 11, 2022
Merged

[Upcoming] Release 1.5.0 #2462

merged 9 commits into from Mar 11, 2022

Conversation

skoudoro
Copy link
Member

@skoudoro skoudoro commented Oct 29, 2021

Preparation for 1.5.0 release, targeting November 7th-8th March 1st.

Desired PR (need review / feedback / update)

There is room for the following PR to be finished and merge

Most of them can be done on time, I think 😄

Please comment to flag any other issues or PR that should be addressed for this release

Release checklist

  • add release_notes 1.5.0
  • Update changelog and api_changes
  • Update .mailmap
  • Set release number in info.py
  • Check the copyright years in doc/conf.py and LICENSE
  • Check documentation
  • Check Tutorial
  • Check unit test and USE-PRE
  • Update index.rst
  • Update Highligth.rst, old_news.rst, stateofheart.rst
  • Update developers.rst list
  • Update website
  • Update deprecation cycle remove long deprecation

@arokem
Copy link
Contributor

arokem commented Oct 29, 2021

Looks like #2461 would be a quick fix. Should we add that to this release?

@skoudoro
Copy link
Member Author

yes, added. #2463 also

@skoudoro
Copy link
Member Author

I think we are ready for the Release. If I find time, I will look #2369 but it should not block the release.

Also, we need to check documentation generation and if there is no surprise with the wheels.

@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #2462 (4a2f621) into master (f809124) will not change coverage.
The diff coverage is n/a.

❗ Current head 4a2f621 differs from pull request most recent head 62c94ab. Consider uploading reports for the commit 62c94ab to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2462   +/-   ##
=======================================
  Coverage   85.08%   85.08%           
=======================================
  Files         129      129           
  Lines       17579    17579           
  Branches     2994     2994           
=======================================
  Hits        14957    14957           
  Misses       1926     1926           
  Partials      696      696           

@skoudoro
Copy link
Member Author

skoudoro commented Mar 3, 2022

As you can see here, the wheels for manyLinux python 3.10 are failing. If someone has any idea on how to fix that. I will appreciate it a lot the help!

@arokem? @matthew-brett @Garyfallidis?

@arokem
Copy link
Contributor

arokem commented Mar 4, 2022

Sorry: this is above my head.

@larsoner
Copy link
Contributor

larsoner commented Mar 4, 2022

The error is ls: /opt/python/cp310-cp310/bin: No such file or directory. Looks like you're using pypa/manylinux1_x86_64. Maybe you need to upgrade to manylinux2010 or later to get 3.10 support? Looks like NumPy and SciPy intentionally removed references to manylinux1 in favor of manylinux:

https://github.com/MacPython/numpy-wheels

I would look to see how they have updated to get 3.10 working...

@skoudoro
Copy link
Member Author

skoudoro commented Mar 4, 2022

Thank you for looking into this @larsoner.

Looks like you're using pypa/manylinux1_x86_64

yes, we are using this in one matrix.

Maybe you need to upgrade to manylinux2010

Another matrix use this one as you can see here but it fails also with the following error:

ERROR: Exception:
Traceback (most recent call last):
  File "/venv/lib/python3.10/site-packages/pip/_internal/cli/base_command.py", line 173, in _main
    status = self.run(options, args)
  File "/venv/lib/python3.10/site-packages/pip/_internal/cli/req_command.py", line 203, in wrapper
    return func(self, options, args)
  File "/venv/lib/python3.10/site-packages/pip/_internal/commands/install.py", line 390, in run
    installed = install_given_reqs(
  File "/venv/lib/python3.10/site-packages/pip/_internal/req/__init__.py", line 73, in install_given_reqs
    requirement.install(
  File "/venv/lib/python3.10/site-packages/pip/_internal/req/req_install.py", line 723, in install
    scheme = get_scheme(
  File "/venv/lib/python3.10/site-packages/pip/_internal/locations/__init__.py", line 155, in get_scheme
    new = _sysconfig.get_scheme(
  File "/venv/lib/python3.10/site-packages/pip/_internal/locations/_sysconfig.py", line 131, in get_scheme
    scheme_name = _infer_prefix()
  File "/venv/lib/python3.10/site-packages/pip/_internal/locations/_sysconfig.py", line 45, in _infer_prefix
    return sysconfig.get_preferred_scheme("prefix")  # type: ignore
AttributeError: module 'sysconfig' has no attribute 'get_preferred_scheme'

I suppose, the VM needs a more recent version of pip. I just do not know how to update it.

or later to get 3.10 support?

I will experiment with a newer one.

Also, it seems that Numpy migrates to cibuildwheel for building Linux and macOS wheels as you can see here

We might do the same move. I will experiment that this morning.

@skoudoro
Copy link
Member Author

skoudoro commented Mar 4, 2022

ok, manylinux1 has been dropped for python3.10, makes sense now. More info on pypa/manylinux#994

@skoudoro
Copy link
Member Author

skoudoro commented Mar 4, 2022

ok, all good with python3.10 and manylinux2014. I will explore cibuildwheel another day.

Finalizing doc generation, checking tutorials and examples.

Changelog Outdated Show resolved Hide resolved
@arokem
Copy link
Contributor

arokem commented Mar 11, 2022

LGTM! Ready to go, I believe.

🚀 ❗ ❗ ❗ ⚡

Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
@Garyfallidis
Copy link
Contributor

Release time! Let's GO! 💯

@Garyfallidis Garyfallidis merged commit d3577cc into dipy:master Mar 11, 2022
@skoudoro skoudoro deleted the rel-preparation branch March 11, 2022 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants