Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Adds support of cython for pytest #3048

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

skoudoro
Copy link
Member

This PR fixes #2719.

The goal is to allow Pytest to run test on *.pyx files and especially cdef function.

Currently, our cedf function are not tested which is quite problematic.

@gabknight, you will be interested to this PR. Also, the cross is failing, Can you look into it a create a new PR to fix it?

Thanks!

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fb4005f) 82.39% compared to head (50afd80) 82.38%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3048      +/-   ##
==========================================
- Coverage   82.39%   82.38%   -0.01%     
==========================================
  Files         146      145       -1     
  Lines       20631    20624       -7     
  Branches     3319     3319              
==========================================
- Hits        16999    16992       -7     
  Misses       2802     2802              
  Partials      830      830              

see 1 file with indirect coverage changes

@skoudoro
Copy link
Member Author

You can see on the CI new tests for pyx files : https://github.com/dipy/dipy/actions/runs/7659584839/job/20875012290?pr=3048#step:9:3779

@gabknight
Copy link
Contributor

Looks good. In my environment, the test test_cross() passes. Could you share the error you are getting.

@Garyfallidis Garyfallidis merged commit c6e9e13 into dipy:master Mar 5, 2024
27 checks passed
@skoudoro skoudoro deleted the pytest-cython branch August 15, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pytest and cdef functions
3 participants