Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NF - Add radial basis function interpolation on the sphere. #41

Merged
merged 2 commits into from Jul 11, 2012

Conversation

stefanv
Copy link
Contributor

@stefanv stefanv commented Jul 7, 2012

No description provided.

@Garyfallidis
Copy link
Contributor

I am getting this error

.............................................../home/eg309/Devel/dipy/dipy/core/sphere.py:161: UserWarning: Vertices are not on the unit sphere.
warnings.warn("Vertices are not on the unit sphere.")

..E....

ERROR: dipy.core.tests.test_sphere.test_interp_rbf

Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/nose/case.py", line 197, in runTest
self.test(*self.arg)
File "/home/eg309/Devel/dipy/dipy/core/tests/test_sphere.py", line 181, in test_interp_rbf
v0, e0, f0 = create_half_unit_sphere(2)
TypeError: 'Sphere' object is not iterable


Ran 54 tests in 0.383s

@stefanv
Copy link
Contributor Author

stefanv commented Jul 9, 2012

Added some fixes to the way triangle_subdivide constructs Spheres. Also added tests for rbf interpolation (oops, how did those get left out initially).

/cc @MrBago

@stefanv
Copy link
Contributor Author

stefanv commented Jul 10, 2012

If you're not sure whether to merge this patch yet, should I submit a separate PR for the fixes to triangle_subdivide? They currently make it impossible to use the Sphere returned by create_unit_sphere(...).

@MrBago
Copy link
Contributor

MrBago commented Jul 10, 2012

Stefan, I think I've made pretty much the same changes in my pull request. Do you mind slitting this pull request up into two and maybe we can modify mine if we need to.

@stefanv
Copy link
Contributor Author

stefanv commented Jul 10, 2012

Done, see #45

@stefanv
Copy link
Contributor Author

stefanv commented Jul 10, 2012

Patch also removed from this PR.

Garyfallidis added a commit that referenced this pull request Jul 11, 2012
NF - Add radial basis function interpolation on the sphere.
@Garyfallidis Garyfallidis merged commit 81a0cf5 into dipy:master Jul 11, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants