Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem
vite-plugin-md
package was updated from0.11.4
to0.14.0
in #13845, but unfortunately it seems to break the in-app docs for Directus9.12.2
now:0.14.0
included one particular sizable change — antfu/vite-plugin-md#77, and I believe the 2 main reasons why it's broken on our end are:DocsWrapper
PascalCase for wrapperComponent is not valid/recognized anymore, which is why any of our docs-wrapper component styling doesn't apply now:directus/app/vite.config.js
Line 26 in 42cb679
This PascalCase wrapperComponent issue is being tracked in Failed to use Vue component in markdown antfu/vite-plugin-md#90.
There is now a
.markdown-body
class applying styles over our custom styles, so even if we were to usedocs-wrapper
in the current0.14.0
or the latest0.15.0
, it is still overriding certain styles, primarily the text color in dark theme.There is currently a PR to fix this in fix: the effect of default style on custom class antfu/vite-plugin-md#85.
Style overridden issue:
Solution
Downgraded
vite-plugin-md
package to0.13.1
temporarily while we await for the additional styling to be removed in a future version.Side note: regarding packages removed in the package-lock file after this downgrade, it's mostly because they were added in
0.14.0
. They have since been removed in0.14.2
.Opted to rename
DocsWrapper
todocs-wrapper
, even if PascalCase still works in0.13.1
as I believe it's more unlikely for kebab-case support to be removed in future versions based on my understanding in that thread.Result
Type of Change
Requirements Checklist
If adding a new feature: