Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input and textarea fields are always getting trimmed #14709

Merged
merged 1 commit into from Jul 28, 2022
Merged

Conversation

br41nslug
Copy link
Member

@br41nslug br41nslug commented Jul 28, 2022

Description

Because the interface settings are saved to the database as null when sticking to the defaults this was getting overwritten by the input and textarea property defaults which were set to trim=true.
I've opted to update the component default properties to be in sync with the interface options defaults.

Fixes #14702

Type of Change

  • Bugfix
  • Improvement
  • New Feature
  • Refactor / codestyle updates
  • Other, please describe:

Requirements Checklist

  • New / updated tests are included
  • All tests are passing locally
  • Performed a self-review of the submitted code

If adding a new feature:

  • Documentation was added/updated

@rijkvanzanten rijkvanzanten added this to the Next Release milestone Jul 28, 2022
@rijkvanzanten rijkvanzanten merged commit 8740f5e into main Jul 28, 2022
@rijkvanzanten rijkvanzanten deleted the issue/14702 branch July 28, 2022 21:41
qborisb pushed a commit to qborisb/directus that referenced this pull request Aug 18, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input and textarea fields are always getting trimmed
2 participants