Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix url encoding query parameters and added tests #17120

Merged
merged 4 commits into from Jan 12, 2023

Conversation

tofran
Copy link
Contributor

@tofran tofran commented Jan 12, 2023

Description

Fixes #17119

  • 700e413: Fixes encoding bug (patch only);
  • 39ca235: Adds missing tests to the Url util, and makes the trailing slash behaviour consistent and documented in the tests;
  • 2d08635: Bumps npm version in the .nvmrc file;

Type of Change

  • Bugfix
  • Improvement
  • Refactor / codestyle updates

Requirements Checklist

  • New / updated tests are included
  • All tests are passing locally
  • Performed a self-review of the submitted code

@rijkvanzanten rijkvanzanten merged commit 0f9f0d8 into directus:main Jan 12, 2023
5 checks passed
@rijkvanzanten rijkvanzanten added API Related to the API Bug Something isn't working labels Jan 12, 2023
Nitwel pushed a commit that referenced this pull request Jan 19, 2023
* fix(utils): query parameters encoding for Url

* improvement(utils): added tests to Url

Also, made trailing slash behaviour consistent

* fix: updated nvmrc to the recommended node version
@licitdev licitdev added this to the Next Release milestone Jan 19, 2023
meditadvisors pushed a commit to ciso360ai/directus-mod that referenced this pull request Mar 3, 2023
* fix(utils): query parameters encoding for Url

* improvement(utils): added tests to Url

Also, made trailing slash behaviour consistent

* fix: updated nvmrc to the recommended node version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Related to the API Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Password reset improperlly handles url-encoded query parameters in reset_url
3 participants