Improve S3 asset read performance #17835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rijkvanzanten
requested review from
a team,
freekrai,
licitdev and
jaads
and removed request for
a team
freekrai
approved these changes
Mar 20, 2023
meditadvisors
pushed a commit
to ciso360ai/directus-mod
that referenced
this pull request
May 13, 2023
* Create new s3 client for each read * Temp disable ts while debugging * Add concurrency test * Add minio to other tests * Reduce unavailable count * Trigger blackbox tests whenever packages are updated * Prevent minio-mc from exiting * Decrease requests and increase test timeout * Spam more requests over longer period * Increase request timeout * Run autocannon directly with larger image * Fix tests * Lock version * My favorite file --------- Co-authored-by: ian <licitdev@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing very large quantities of read requests, the S3 Client has the chance to slow down / stall the process completely. By using a fresh S3 client instance for each read request, the API is able to process way more traffic from S3.
Todo
index.test.ts