Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 1
When the page goes "idle", the refresh timeout is cleared.
directus/app/src/auth.ts
Lines 47 to 55 in 6db9e0c
However, it is not re-added when the page becomes active again.
Issue 2
isRefreshing
flag is permanently true if it is valid for the following conditional check.directus/app/src/auth.ts
Lines 81 to 88 in 6db9e0c
Fixes
Set a new timeout if the token is still fresh.
Shifted the setting of the
isRefreshing
flag after the conditional check.In addition, I have removed a check for
isRefreshing
as it is redundant.directus/app/src/auth.ts
Line 106 in 6db9e0c