Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build template selectors by selecting data-ids within template, not by all-keys #49

Closed
dirv opened this issue Aug 25, 2015 · 1 comment
Closed

Build template selectors by selecting data-ids within template, not by all-keys #49

dirv opened this issue Aug 25, 2015 · 1 comment
Assignees
@dirv
Labels
high-priority

Comments

@dirv
Copy link
Owner

dirv commented Aug 25, 2015

There's an all-keys function which is used to generate selectors that match each field in a page.

Pages can potentially have quite a large selection of headers, only a subset of which will be used. In addition, each page has a call to all-keys when the template is run.

If instead Pinaclj builds a list of selectors based on the template, it can store this off when the template is first run and then simply call it back for each page that uses it.
@dirv dirv self-assigned this Aug 25, 2015
@dirv
Copy link
Owner Author

dirv commented Aug 25, 2015

Fixed

@dirv dirv closed this as completed Aug 25, 2015
@dirv dirv changed the title Build template selectors by selecting data-id's within template, not by all-keys Build template selectors by selecting data-ids within template, not by all-keys Aug 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dirv dirv

Labels
high-priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dirv