Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Refactor HTML to implement NL Design System #134

Merged
merged 6 commits into from Mar 20, 2020

Conversation

@patrickbroens
Copy link
Contributor

patrickbroens commented Mar 19, 2020

No description provided.

pimotte and others added 4 commits Mar 18, 2020
This patch replaces the HTML markup with markup
which is compliant to the NL Design System.

Depends on #131
@patrickbroens patrickbroens requested a review from pimotte Mar 19, 2020
@pimotte pimotte added this to Review in progress in discipl dev Mar 19, 2020
Copy link
Contributor

pimotte left a comment

Semantically the changes look good to me. Thanks!

The integration test did break, though. Would you like to fix that yourself? (If not, that's fine and I'll take it from here)

@patrickbroens

This comment has been minimized.

Copy link
Contributor Author

patrickbroens commented Mar 19, 2020

@pimotte The integration was based on your MR #131, which has the same CI checks failing. If you could do the honors to fix it, I would be grateful. If you merge this one, your MR #131 can be abandoned.

Copy link
Contributor

pimotte left a comment

🎇

Thanks!

discipl dev automation moved this from Review in progress to Reviewer approved Mar 20, 2020
@pimotte pimotte merged commit 58825e6 into master Mar 20, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
discipl dev automation moved this from Reviewer approved to Done Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
discipl dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.