small fix for quote vs quote_plus #11

Merged
merged 1 commit into from Feb 22, 2012

2 participants

@jesseward

The upstream requests library has caused a few issues over the last month. Namely URL escaping of special characters.

This is now fixed. I believe requests lib 10.1 -> 10.3 should be considered "broken"
See
kennethreitz/requests#404
kennethreitz/requests#437

This pull requests includes a very small change to the way the client encodes urls. Substituting quote() for quote_plus() (discogs uses the + for slugs)

See

http://docs.python.org/library/urllib.html#urllib.quote

"Like quote(), but also replaces spaces by plus signs, as required for quoting HTML form values when building up a query string to go into a URL. Plus signs in the original string are escaped unless they are included in safe. It also does not have safe default to '/' "

@vreon vreon merged commit bfdb1f9 into discogs:master Feb 22, 2012
@vreon
Discogs member

Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment