Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode hash to string, not byte sequence #3

Merged
merged 2 commits into from Jan 20, 2017

Conversation

@stlk
Copy link
Contributor

@stlk stlk commented Jan 19, 2017

Not decoding caused comparison to fail on Python 3.6

Not decoding caused comparison to fail on Python 3.6
@gavinballard
Copy link
Member

@gavinballard gavinballard commented Jan 19, 2017

Thanks for the contribution @stlk! Could you please provide a test for this behaviour, so that I can make sure this change works OK on Python 2 and a range of Django versions?

Use appropriate text type for fake headers.
@stlk
Copy link
Contributor Author

@stlk stlk commented Jan 20, 2017

Thanks for writing this package and quick reply!

Method I changed is already tested. I managed to come up with small improvement. I changed the WebhookTestCase.post_shopify_webhook so the HTTP_X_SHOPIFY_HMAC_SHA256 header uses six.text_type to be more version aware.

@gavinballard
Copy link
Member

@gavinballard gavinballard commented Jan 20, 2017

Awesome, thanks @stlk!

@gavinballard gavinballard merged commit 9aac120 into discolabs:master Jan 20, 2017
1 check passed
@stlk stlk deleted the fix/bytes-to-string branch Jan 20, 2017
@gavinballard
Copy link
Member

@gavinballard gavinballard commented Jan 20, 2017

@stlk This change has been released to Pypi as v0.3.1. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants