Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

worker should automatically package up all required modules without weird limitations #328

Closed
tubaman opened this Issue · 8 comments

4 participants

Ryan Nowakowski Prashanth Mundkur Reid Priedhorsky Shayan Pooya
Ryan Nowakowski

Currently, the classic worker has some strange requirements for automatically detecting the required modules used in a job. For example, packages aren't supported. The classic worker should be changed to automatically detect all required modules(including packages).

Ryan Nowakowski

Here's a worker that meets the criteria:

https://gist.github.com/3515397

Prashanth Mundkur
Owner

If you can add a test under tests/ for this, we can pull it.

Ryan Nowakowski
Reid Priedhorsky

+1 for "weird limitations". imports are insanely confusing under Disco.

Shayan Pooya
Owner

@tubaman Any updates on this? Could you please create a pull request?

Ryan Nowakowski
Shayan Pooya
Owner

N worries. I'll see if I can get this tested and merged in.

Shayan Pooya
Owner

The useful parts have been added to Disco. Thanks.

Shayan Pooya pooya closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.