Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODiX doesn't maintain spoilers when linking to a message containing an embed #705

Open
tannergooding opened this issue Feb 5, 2020 · 3 comments

Comments

@tannergooding
Copy link

@tannergooding tannergooding commented Feb 5, 2020

If linking to a message which was spoilered and contains an embed, the embed will no longer be spoilered when MODiX creates it's own new embed.

This is particularly problematic for NSFW content.

@tannergooding

This comment has been minimized.

Copy link
Author

@tannergooding tannergooding commented Feb 5, 2020

image

@Cisien

This comment has been minimized.

Copy link
Collaborator

@Cisien Cisien commented Feb 5, 2020

gotta protect that community standup!

@FiniteReality

This comment has been minimized.

Copy link
Contributor

@FiniteReality FiniteReality commented Feb 6, 2020

Something I mentioned to tanner while he was reproing this:

  • Ignore any spoilered attachments (they start with SPOILER_) and ignore images in embeds if the message is spoilered
  • Instead just link to the message and say "this message contains spoilered content" or something

Alternatively, if you want to use attachments, you can do this:

  • Get the stream of the image
  • Upload it in the message as an attachment with the name SPOILER_<someHash>.<format>
  • Reference it as attachment://SPOILER_<theHash>.<format> instead of the image url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.