Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Guild and Message Models #1165

Merged

Conversation

Projects
None yet
3 participants
@Chris-Johnston
Copy link
Contributor

commented Oct 1, 2018

This PR includes many updates to the Guild and Message API models and their related classes.
Fixes #1113 .

Guild:

  • Adds the ExplicitContentFilter property and ExplicitContentFilterLevel type
    • Add a test for this property's ModifyAsync behavior
  • Adds the ApplicationID property.
    • Can test this by having a bot create a new guild, then checking that the ApplicationId property is not null. This is not viable to include as part of the bot's integration tests in CI, as bots can only create up to 10 guilds iirc.

Message:

  • Adds the Activity property and MessageActivity, MessageActivityType types
    • Can test this by inviting a channel w/ bot to listen along on Spotify
  • Adds the Application property and the MessageApplication type
    • Can test this (and Activity) by inviting a channel w/ bot to a Fortnite lobby (I actually had to install the game to test this behavior)
      image

This commit log may look a bit strange because of an issue when resolving merge conflicts.

@Chris-Johnston Chris-Johnston changed the title Implement Guild Explicit Content Filter and Application ID Update Guild and Message Models Oct 5, 2018

Chris-Johnston added some commits Oct 5, 2018

@foxbot foxbot merged commit d30d122 into discord-net:dev Oct 19, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.