Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for parsing multiple types of quotation marks in commands, Fix #942 #943

Merged
merged 23 commits into from May 25, 2018

Conversation

Projects
None yet
10 participants
@Chris-Johnston
Copy link
Contributor

commented Jan 28, 2018

#942 brings up the issue that non-remainder string parameters of commands cannot be parsed with non-standard double quotation marks ("). I added a list of quotation mark aliases to the CommandServiceConfig. This means the library can now parse unicode double quotation marks and also culture-specific ones (like and «).

I used aliases that were mentioned in the d.net channel, but I'm not certain what the default values should be set to.

I would like to get feedback if anything needs improvement. My discord handle in the channel is @ChrisJ#8703.

Testing Method:
I wanted to test that a single string could be parsed correctly when wrapped in multiple types of quotation marks. Here's a command that I used:

[Command("testcmd")]
public async Task TestCmd(string txt, int aNumber)
{
    await ReplyAsync($"{txt} {aNumber}");
}

And sample execution yields:
-testcmd "test" 123 => test 123 (normal behavior)
-testcmd “test\“cmd\"“ 123 => test“cmd" 123 (escaping still works)
-testcmd «this is a multiple word string» 123 => this is a multiple word string 123
-testcmd «you can mix and match" 456 => you can mix and match 456

@Emzi0767

This comment has been minimized.

Copy link
Contributor

commented Jan 28, 2018

I don't think mix and match is correct behaviour. What happens if: !test «test" argument»? Your code would make it throw or parse otherwise incorrectly, whereas it should pass test" arguments.

For reference, here's a map of various quote kinds:

  • " -> "
  • ' -> '
  • « -> »
  • ->
  • ->
  • ->
  • ->
  • ->
  • ->
  • ->
  • ->
  • ->
  • ->
  • ->
  • ->
  • ->
  • ->
  • ->
@Chris-Johnston

This comment has been minimized.

Copy link
Contributor Author

commented Jan 28, 2018

For the purposes of outlining how I would approach fixing mismatched quotation marks, here's a gist that shows how I would do it it: https://gist.github.com/Chris-Johnston/37b37e70246562c27f0a42d6bd8eda74

Using this, I've been able to produce the correct output.

image

Do you think that this is the correct approach?

@Emzi0767

This comment has been minimized.

Copy link
Contributor

commented Jan 28, 2018

I think you should not allow mix and match behaviour at all. Just match the outermost quote.

@khionu

This comment has been minimized.

Copy link
Contributor

commented Jan 28, 2018

Mmm. Mix and match is an anti-pattern. Additionally, one might use one type of quotes in order to allow regular quotes inside the used quotes

@Chris-Johnston

This comment has been minimized.

Copy link
Contributor Author

commented Jan 29, 2018

Changing this to a map was a good idea.
Now using the same command I'm able to do: -testcmd «all ‘the “quotes 「」”’ ! ! " " » 123 and get back all ‘the “quotes 「」”’ ! ! " " 123.

So it's allowing for different types of quotation marks to be nested without needing to be escaped.
Mix and match is no longer allowed.

@Joe4evr
Copy link
Contributor

left a comment

Can do with a few minor tweaks.

@@ -45,6 +46,7 @@ public CommandService(CommandServiceConfig config)
_ignoreExtraArgs = config.IgnoreExtraArgs;
_separatorChar = config.SeparatorChar;
_defaultRunMode = config.DefaultRunMode;
_quotationMarkAliasMap = config.QuotationMarkAliasMap;

This comment has been minimized.

Copy link
@Joe4evr

Joe4evr Jan 29, 2018

Contributor

Make an ImmutableDictionary out of it here?

Well, I guess the consideration is: do we want to guarantee immutable semantics internally, or fake it and take a perf win but also allow the map to be mutated while the client is running (which isn't too hard to do while implemented this way)? cc: @foxbot @FiniteReality

Either way, I'd make the storage field an IReadOnlyDictionary.

This comment has been minimized.

Copy link
@Joe4evr

Joe4evr Jan 29, 2018

Contributor

For completion's sake: There is a third option where we can fake the immutable semantics, but make it much harder for users to modify the map after initialization. (Still wouldn't completely prevent it, though.)

This comment has been minimized.

Copy link
@Chris-Johnston

Chris-Johnston Jan 29, 2018

Author Contributor

For now, I've left this as an IReadOnlyDictionary. I found that when the dictionary could be modified by the user externally it didn't break anything, but I could understand that being a poor design decision.

This comment has been minimized.

Copy link
@Chris-Johnston

Chris-Johnston Jan 29, 2018

Author Contributor

Oh, I didn't see your second comment. I think I ended up doing your third option. I've been able to test it like this:

CommandServiceConfig config = new CommandServiceConfig();
var d = new Dictionary<char, char>()
{
    { '-', '-' },
    {'\"', '\"' }
};
config.QuotationMarkAliasMap = d;
commands = new CommandService(config);
d.Add('~', '~');

Again, I've found that it still works but might not be the intended idea.

This comment has been minimized.

Copy link
@Joe4evr

Joe4evr Jan 29, 2018

Contributor

Nah, that's the first thing that I talked about. The third option would be to do

_quotationMarkAliasMap = new Dictionary(config.QuotationMarkAliasMap);

Also, the type on the CommandServiceConfig didn't need to be changed to IReadOnlyDictionary. This now prohibits doing the following:

new CommandServiceConfig()
{
    QuotationMarkAliasMap =
    {
        { '[', ']' } //for example
    }
};

This comment has been minimized.

Copy link
@Joe4evr

Joe4evr Jan 29, 2018

Contributor

But anyway, I'd like to hear fox and finite's inputs. Do we want the internals to be semantically correct, or not take a perf hit?

This comment has been minimized.

Copy link
@FiniteReality

FiniteReality Jan 29, 2018

Collaborator

I'd say make an ImmutableDictionary out of it, because that's what we do in other places .

@@ -13,7 +14,33 @@ private enum ParserPart
Parameter,
QuotedParameter
}


private static bool isOpenQuote(Dictionary<char,char> map, char c)

This comment has been minimized.

Copy link
@Joe4evr

Joe4evr Jan 29, 2018

Contributor
  • Use PascalCase
  • Can take the map in as an IReadOnlyDictionary
  • Can be made a local function inside ParseArgsAsync

(Same goes for getMatch)

@@ -13,7 +14,7 @@ private enum ParserPart
Parameter,
QuotedParameter
}

This comment has been minimized.

Copy link
@FiniteReality

FiniteReality Jan 29, 2018

Collaborator

Please remove unnecessary whitespace

if (dict != null)
{
char value;
if (dict.TryGetValue(c, out value))

This comment has been minimized.

Copy link
@FiniteReality

FiniteReality Jan 29, 2018

Collaborator

out var value would probably preferable here

@@ -97,7 +125,7 @@ private enum ParserPart
}
else if (curPart == ParserPart.QuotedParameter)
{
if (c == '\"')
if(c == matchQuote)

This comment has been minimized.

Copy link
@FiniteReality

FiniteReality Jan 29, 2018

Collaborator

Missing whitespace after if

@@ -74,9 +100,11 @@ private enum ParserPart
argBuilder.Append(c);
continue;
}
if (c == '\"')

if(IsOpenQuote(command._quotationAliases, c))

This comment has been minimized.

Copy link
@FiniteReality

FiniteReality Jan 29, 2018

Collaborator

Missing whitespace after if

@@ -45,6 +46,7 @@ public CommandService(CommandServiceConfig config)
_ignoreExtraArgs = config.IgnoreExtraArgs;
_separatorChar = config.SeparatorChar;
_defaultRunMode = config.DefaultRunMode;
_quotationMarkAliasMap = config.QuotationMarkAliasMap;

This comment has been minimized.

Copy link
@FiniteReality

FiniteReality Jan 29, 2018

Collaborator

I'd say make an ImmutableDictionary out of it, because that's what we do in other places .

/// <summary> Collection of aliases that can wrap strings for command parsing.
/// represents the opening quotation mark and the value is the corresponding closing mark.</summary>
public Dictionary<char, char> QuotationMarkAliasMap { get; set; }
= new Dictionary<char, char>()

This comment has been minimized.

Copy link
@FiniteReality

FiniteReality Jan 29, 2018

Collaborator

Redundant parentheses here. Do we need the type name too?

This comment has been minimized.

Copy link
@Joe4evr

Joe4evr Jan 29, 2018

Contributor

Type name is required until dotnet/csharplang#100 lands. Do we omit the parentheses in other places too?

This comment has been minimized.

Copy link
@FiniteReality

FiniteReality Jan 29, 2018

Collaborator

I'm pretty sure we omit the parentheses where possible.

This comment has been minimized.

Copy link
@Chris-Johnston

Chris-Johnston Jan 30, 2018

Author Contributor

GitHub doesn't seem to show this as outdated correctly, but please see commit 8187f35

@@ -20,6 +20,7 @@ public class CommandInfo

private readonly CommandService _commandService;
private readonly Func<ICommandContext, object[], IServiceProvider, CommandInfo, Task> _action;
internal readonly IReadOnlyDictionary<char,char> _quotationAliases;

This comment has been minimized.

Copy link
@FiniteReality

FiniteReality Jan 29, 2018

Collaborator

IMO this should not be stored on the command, but I'm not sure if we have the ability to pass the command service to the parser where ParseArgsAsync is called. Might be worth taking a look?

This comment has been minimized.

Copy link
@Chris-Johnston

Chris-Johnston Jan 29, 2018

Author Contributor

I looked at this again, and found that I could use the similar behavior of IgnoreExtraArgs.

https://github.com/Chris-Johnston/Discord.Net/blob/46e9cf64f3d3635de872720c308e922b13ab8114/src/Discord.Net.Commands/Info/CommandInfo.cs#L124

@Joe4evr

This comment has been minimized.

Copy link
Contributor

commented Jan 30, 2018

LGTM :shipit:

@FiniteReality
Copy link
Collaborator

left a comment

Just a few more niggling things, and it'll be ready to merge

@@ -1,4 +1,5 @@
namespace Discord.Commands
using System.Collections.Generic;
namespace Discord.Commands

This comment has been minimized.

Copy link
@FiniteReality

FiniteReality Jan 30, 2018

Collaborator

Newline between these for consistency

}

public static async Task<ParseResult> ParseArgsAsync(CommandInfo command, ICommandContext context, bool ignoreExtraArgs, IServiceProvider services, string input, int startPos)
}

This comment has been minimized.

Copy link
@SubZero0

SubZero0 Feb 1, 2018

Contributor

Missing new line between enum and method

This comment has been minimized.

Copy link
@Chris-Johnston

Chris-Johnston Feb 1, 2018

Author Contributor

I must have mistook "remove unnecessary whitespace" as the line instead of the space after. Fixed now.

char GetMatch(IReadOnlyDictionary<char, char> dict, char ch)
{
// get the corresponding value for the key, if it exists
if (dict != null)

This comment has been minimized.

Copy link
@AntiTcb

AntiTcb Feb 2, 2018

Contributor

This could just be reduced down to (dict != null && dict.TryGetValue(c, out var value)).

This comment has been minimized.

Copy link
@acid-chicken

acid-chicken May 11, 2018

Contributor

@AntiTcb How about (dict?.TryGetValue(c ,out var value) ?? false)?

This comment has been minimized.

Copy link
@Joe4evr

Joe4evr May 11, 2018

Contributor

Or just make sure that the collection that gets passed in is always initialized so that it's at least empty?

This comment has been minimized.

Copy link
@Chris-Johnston

Chris-Johnston May 12, 2018

Author Contributor

I like the idea of assuming that the collection is always initialized. Added in 820f9e3

@ufcpp

This comment has been minimized.

Copy link

commented Feb 3, 2018

Here is open/close and initial/final quote punctuation pairs generated by https://gist.github.com/ufcpp/5b2cf9a9bf7d0b8743714a0b88f7edc5

()༺༻༼༽᚛᚜‘’“”‹›⁅⁆⌈⌉⌊⌋❨❩❪❫❬❭❮❯❰❱❲❳❴❵⟅⟆⟦⟧⟨⟩⟪⟫⟬⟭⟮⟯⦃⦄⦅⦆⦇⦈⦉⦊⦋⦌⦍⦎⦏⦐⦑⦒⦓⦔⦕⦖⦗⦘⧘⧙⧚⧛⧼⧽⸂⸃⸄⸅⸉⸊⸌⸍⸜⸝⸠⸡⸢⸣⸤⸥⸦⸧⸨⸩〈〉《》「」『』【】〔〕〖〗〘〙〚〛〝〞
{'〔', '〕' },
{'〖', '〗' },
{'〘', '〙' },
{'〚', '〛' }

This comment has been minimized.

Copy link
@FiniteReality

FiniteReality Feb 3, 2018

Collaborator

IMO if we're adding a large dict of things like this, it might be better to use a separate file for it instead. I'm not sure though.

This comment has been minimized.

Copy link
@Chris-Johnston

Chris-Johnston Feb 4, 2018

Author Contributor

Do you mean deserializing the dictionary from another file, or another file in the source that defines the default value of this dictionary?

I think that including all of these by default is a good idea. Alternatively we could shorten this list and include a more complete one in the documentation.

This comment has been minimized.

Copy link
@FiniteReality

FiniteReality Feb 4, 2018

Collaborator

Another file in source, yeah, like the emoji map text template. It may be possible for us to re-use some of the code suggested by @ufcpp so that we can generate these automatically and keep them up-to-date when Unicode inevitably changes.

This comment has been minimized.

Copy link
@Chris-Johnston

Chris-Johnston Feb 5, 2018

Author Contributor

It looks like that gist uses features that aren't supported in .netstandard1.1 (or 1.3) https://docs.microsoft.com/en-us/dotnet/api/system.char.getunicodecategory?view=netcore-2.0#Applies_to
https://docs.microsoft.com/en-us/dotnet/api/system.string.normalize?view=netcore-2.0#Applies_to

So for now it may be best to define this dictionary in another file and leave it, unless/until we target netstandard2

Chris-Johnston added some commits Feb 5, 2018

@Chris-Johnston

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2018

#1043 ~~~replaces ns1.3 with ns2.0~~~ targets netstandard2.0. if it is merged, we will be able to support generating quotation mark pairs programmatically, see the comment thread immediately above

Edit: I misread. Ns2.0 is added here, but not replacing ns1.3. So I'm not sure if the generation would be viable.

Chris-Johnston added some commits May 12, 2018

@foxbot foxbot merged commit cee71ef into discord-net:dev May 25, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@Chris-Johnston Chris-Johnston deleted the Chris-Johnston:quotationMarks branch May 25, 2018

Still34 added a commit to Still34/Discord.Net that referenced this pull request May 29, 2018

Squashed commit of the following:
commit 17a4af7
Author: Still Hsu <341464@gmail.com>
Date:   Tue May 29 17:15:10 2018 +0800

    Add documentation for new API version & few events

commit f4fb027
Merge: d74c528 3acf2a9
Author: Still Hsu <341464@gmail.com>
Date:   Tue May 29 08:25:41 2018 +0800

    Merge remote-tracking branch 'upstream/dev' into docs/faq-n-patches-offline

commit 3acf2a9
Author: HelpfulStranger999 <helpfulstranger999@gmail.com>
Date:   Mon May 28 14:59:30 2018 -0500

    Refactors readMessages, fixing from discord-net#1033 (discord-net#1075)

commit 513a489
Author: Christopher F <foxbot@protonmail.com>
Date:   Mon May 28 15:45:42 2018 -0400

    codefix: add VoiceAPIVersion constant to DiscordConfig

commit 9ba38d7
Author: Christopher F <foxbot@protonmail.com>
Date:   Mon May 28 15:35:59 2018 -0400

    api: upgrade audio client to VoiceWS v3

commit 64d8938
Author: Christopher F <foxbot@protonmail.com>
Date:   Mon May 28 15:25:46 2018 -0400

    fix: Discord does not always send the member on VOICE_STATE_UPDATE

    some guilds aren't on g250k yet? not sure

commit aeb3095
Author: FiniteReality <digpoealternate@gmail.com>
Date:   Mon May 28 17:48:38 2018 +0100

    Remove Debug.Print call causing tests to fail

    Forgot to hit save properly... Whoops.

commit a718a7d
Author: Christopher F <foxbot@protonmail.com>
Date:   Mon May 28 12:45:49 2018 -0400

    cleanup: Remove ChannelHelper#IsNsfw

    Closes discord-net#1074

    This code was not referenced anywhere in the active codebase.

commit 0c7cb73
Author: FiniteReality <digpoealternate@gmail.com>
Date:   Mon May 28 17:41:05 2018 +0100

    Fix permission-related ViewChannel tests

commit 415e2f7
Author: FiniteReality <digpoealternate@gmail.com>
Date:   Mon May 28 17:14:18 2018 +0100

    Fix analyzer warnings with tests

    Use (actual, expected) format for Assert.Equal, fixes analyzer warnings

commit b004260
Author: FiniteReality <digpoealternate@gmail.com>
Date:   Mon May 28 17:13:59 2018 +0100

    Move RpcCategoryChannel into the correct project

commit 683b3f2
Author: FiniteReality <digpoealternate@gmail.com>
Date:   Mon May 28 17:12:28 2018 +0100

    Mark ChannelHelper.IsNsfw Obsolete

    Discord no longer treats channels prefixed with 'nsfw' as NSFW,
    so we no longer need to have this check.

commit d74c528
Merge: 341b958 237ad0f
Author: Still Hsu <341464@gmail.com>
Date:   Mon May 28 11:48:47 2018 +0800

    Merge branch 'dev' into docs/faq-n-patches-offline

commit 237ad0f
Author: Christopher F <foxbot@protonmail.com>
Date:   Sun May 27 18:00:51 2018 -0400

    Revert "fix: Properly rethrow exceptions in SocketGuild audio client"

    This reverts commit adf4da1.

    Someone hasn't written c# in a while

commit adf4da1
Author: Christopher F <foxbot@protonmail.com>
Date:   Sun May 27 17:56:14 2018 -0400

    fix: Properly rethrow exceptions in SocketGuild audio client

commit c0c565f
Author: Christopher F <foxbot@protonmail.com>
Date:   Sun May 27 16:45:54 2018 -0400

    retain fallback case for if user is still null

commit 8fb2c71
Author: Christopher F <foxbot@protonmail.com>
Date:   Sun May 27 16:37:17 2018 -0400

    Add new member objects to events

commit 341b958
Author: Still Hsu <341464@gmail.com>
Date:   Sun May 27 19:01:04 2018 +0800

    Add documentation

commit 2df635e
Merge: 180b20d 9995cab
Author: Still Hsu <341464@gmail.com>
Date:   Sun May 27 18:25:51 2018 +0800

    Merge pull request #1 from Chris-Johnston/better-documentation-for-quotation-mark-aliases

    Improve XML docs for commands quotation mark aliases feature

commit 180b20d
Author: Still Hsu <341464@gmail.com>
Date:   Sun May 27 18:19:20 2018 +0800

    Add documentation for new INestedChannel

commit e9f72b6
Author: Still Hsu <341464@gmail.com>
Date:   Sun May 27 18:18:52 2018 +0800

    Fix missing service provider in example

commit 9995cab
Merge: a8d3031 1a146af
Author: Chris Johnston <chris@thejohnstons.net>
Date:   Sun May 27 01:11:17 2018 -0700

    Merge branch 'docs/faq-n-patches-offline' into better-documentation-for-quotation-mark-aliases

commit a8d3031
Author: Chris Johnston <chris@thejohnstons.net>
Date:   Sat May 26 23:32:40 2018 -0700

    Add explanation that if " is removed then it wont work

commit cb7c6d3
Author: Chris Johnston <chris@thejohnstons.net>
Date:   Sat May 26 23:29:32 2018 -0700

    Add reference to CommandServiceConfig from the util docs'

commit 110b975
Author: Chris Johnston <chris@thejohnstons.net>
Date:   Sat May 26 23:15:01 2018 -0700

    Add more XML comments to quotation mark alias map stuff, including an example

commit 1a146af
Merge: cb57ada a06e212
Author: Still Hsu <341464@gmail.com>
Date:   Sun May 27 11:25:10 2018 +0800

    Merge branch 'dev' into docs/faq-n-patches-offline

commit a06e212
Author: Chris Johnston <chris@thejohnstons.net>
Date:   Sat May 26 11:15:09 2018 -0700

    Fix ChannelPermissions Modify parameter to be correct default value (discord-net#1003)

    * fix channel permissions modify parameter to use nullable boolean, correct default value

    * Add general tests for the ChannelPermissions.Modify method to test default values

    * remove unused cast in tests

    * add guildpermission modify no param tests

    * Add no-param modify tests for OverwritePermissions

    * fix inconsistent parameters in GuildPermissions cstr

    * Adjust formatting of methods and cstrs with many parameters

    * remove temp file that was included. no idea what that is

    * Fix System dependency

    I should really stop fixing merge conflicts in the github website.

commit f9cbff5
Author: Chris Johnston <chris@thejohnstons.net>
Date:   Sat May 26 11:06:35 2018 -0700

    Fix discord-net#995, Move Category Implementation from IGuildChannel to INestedChannel (discord-net#1004)

    * Fix discord-net#995 ICategoryChannel.CategoryID throws NotSupportedException

    * Add tests

    * change run mode of TestChannelCategories

    * Add throw for GetCategoryAsync

    * Add xml doc explaining why exception is thrown

    * Add test coverage for text and voice channel categories

    * initial implementation of INestedChannel

    * more implementation of INestedChannel design

    * Add case in RestChannel Create for Category type

    * set the CategoryID for RestVoiceChannel

    * rewrite channel category tests to work with existing pattern

    * remove outdated todo

    * Make IVoiceChannel implement INestedChannel

    * remove redundant interface implementation

    * Add c#7 feature from feedback

    * Remove redundant GetCategoryAsync methods from socket entities

    * Added configureawait to async methods

    * change signature of interface GetCategoryAsync

    * Add check for cachemode in rest channel GetCategory

    * remove redundant IGuildChannel interface from ITextChannel and IVoiceChannel

commit 4d8764e
Author: FiniteReality <digpoealternate@gmail.com>
Date:   Sat May 26 14:11:49 2018 +0100

    Refactor RoleInfo types into separate classes

    - Fixes indentation with a few files (looks like a bad copy+paste job)
    - Renames RoleInfo to RoleEditInfo
    - Moves RoleInfo from MemberRoleAuditLogData into its own class

    All of this should improve docs.

commit cb57ada
Author: Still Hsu <341464@gmail.com>
Date:   Sat May 26 21:03:07 2018 +0800

    Add partial documentation for audit log objects

commit afda0cd
Author: Still Hsu <341464@gmail.com>
Date:   Sat May 26 20:47:21 2018 +0800

    Add documentation for some REST-based objects

commit 098ead9
Author: Still Hsu <341464@gmail.com>
Date:   Sat May 26 16:33:38 2018 +0800

    Add partial documentation for audit log impl

commit 5d1621a
Author: Still Hsu <341464@gmail.com>
Date:   Sat May 26 16:06:20 2018 +0800

    Fix xml docs error

commit 596b47e
Merge: 3f572cc fa759a2
Author: Still Hsu <341464@gmail.com>
Date:   Sat May 26 15:54:08 2018 +0800

    Merge branch 'dev' into docs/faq-n-patches-offline

commit 3f572cc
Merge: 73ebc02 a998302
Author: Still Hsu <341464@gmail.com>
Date:   Sat May 26 15:32:38 2018 +0800

    Merge branch 'docs/faq-n-patches-offline' of https://github.com/Still34/Discord.Net into docs/faq-n-patches-offline

commit 73ebc02
Author: Still Hsu <341464@gmail.com>
Date:   Sat May 26 15:32:23 2018 +0800

    Fix light theme link color

commit fa759a2
Author: Chris Johnston <chris@thejohnstons.net>
Date:   Fri May 25 06:38:59 2018 -0700

    Remove Build Warnings for Obsolete Guild Permission Read Messages (discord-net#1067)

    - Replaces the usages of `ReadMessages` with `ViewChannel`
    - Renames the read message parameters of `GuildPermissions#Modify` to be view channel as well

commit bbbac85
Author: Hawx <Hawxy@users.noreply.github.com>
Date:   Fri May 25 20:14:28 2018 +0800

    Update Dependencies and support NS2.0 builds (discord-net#1046)

    * Update deps, fix test warnings.

    * Support ns2.0

    * Fix typo

    * Remove ns1.1 support

    * Net.Http and Net.Websockets.Client are not needed in ns2.0

    * Move to net46 per volt

    * Remove ns1.3 constants

commit 5f084ad
Author: HelpfulStranger999 <helpfulstranger999@gmail.com>
Date:   Thu May 24 19:17:19 2018 -0500

    Deprecates ReadMessages, introduces ViewChannel (discord-net#1033)

    * Deprecates ReadMessages, introduces ViewChannel

    * Adds period and comma somehow missed

commit bc6009e
Author: Still Hsu <341464@gmail.com>
Date:   Fri May 25 08:08:51 2018 +0800

    Implement IMessageChannel#DeleteMessageAsync (discord-net#996)

    * Implement DeleteMessageAsync

    * Refer to MessageHelper instead of duplicating call

    * Fix refactor error

commit cee71ef
Author: Chris Johnston <chris@thejohnstons.net>
Date:   Thu May 24 17:07:37 2018 -0700

    Add support for parsing multiple types of quotation marks in commands, Fix discord-net#942 (discord-net#943)

    * Add ability to support different types of quotation marks

    * Added normal quotation mark to list of aliases, removed single quote mark

    * clean up leftover changes from testing

    * change quotation mark parsing to use a map of matching pairs

    * remove commented out code

    * Fix conventions of the command parser utility functions

    * change storage type of alias dictionary to be IReadOnlyDictionary

    * revert type of CommandServiceConfig QuotationMarkAliasMap to Dictionary

    * minor formatting changes to CommandParser

    * remove unnecessary whitespace

    * Move aliases outside of CommandInfo class

    * copy IReadOnlyDictionary to ImmutableDictionary

    * minor syntax changes in CommandServiceConfig

    * add newline before namespace for consistency

    * newline formatting tweak

    * simplification of GetMatch method for CommandParser

    * add more quote unicode punctuation pairs

    * add check for null value when building ImmutableDictionary

    * Move default alias map into a separate source file

    * Ensure that the collection passed into command service is not null

commit b52af7a
Author: Joe4evr <jii.geugten@gmail.com>
Date:   Fri May 25 01:59:32 2018 +0200

    Add a dedicated TimeSpan reader so it doesn't suck (discord-net#1005)

    * Add a dedicated TimeSpan reader so it doesn't suck

    * Pass input as lower case

commit c275e57
Author: o Acid Chicken (硫硫▒~E▒▒▒~O) <root@acid-chicken.com>
Date:   Thu May 24 19:52:25 2018 -0400

    Add support casting System.Drawing.Color to Discord.Color

    commit fa33034
    Author: Acid Chicken (硫酸鶏) <root@acid-chicken.com>
    Date:   Sun Apr 29 13:50:56 2018 +0900

        Use built-in symbol

        refs: discord-net#1043 (comment)

    commit 27ea826
    Author: Acid Chicken (硫酸鶏) <root@acid-chicken.com>
    Date:   Sun Apr 29 11:29:31 2018 +0900

        Add support casting System.Drawing.Color to Discord.Color

    commit 1ab9de2
    Merge: f5bb99c a4d1e2b
    Author: Acid Chicken (硫酸鶏) <root@acid-chicken.com>
    Date:   Sun Apr 29 10:16:46 2018 +0900

        Merge remote-tracking branch 'upstream/dev' into dev

    commit f5bb99c
    Merge: 3be8e40 b8b59d9
    Author: Acid Chicken (硫酸鶏) <root@acid-chicken.com>
    Date:   Tue Apr 10 11:07:36 2018 +0900

        Merge remote-tracking branch 'upstream/dev' into dev

    commit 3be8e40
    Merge: c692306 9d77a3c
    Author: Acid Chicken (硫酸鶏) <root@acid-chicken.com>
    Date:   Sun Jan 7 15:05:31 2018 +0900

        Merge remote-tracking branch 'upstream/dev' into dev

    commit c692306
    Author: Acid Chicken (硫酸鶏) <root@acid-chicken.com>
    Date:   Sat Nov 11 10:49:00 2017 +0900

        Add target of the internal fields

    commit 2d08f9a
    Author: Acid Chicken (硫酸鶏) <root@acid-chicken.com>
    Date:   Sat Nov 11 10:17:42 2017 +0900

        Add some more extension

    commit 4f19b83
    Author: Acid Chicken (硫酸鶏) <root@acid-chicken.com>
    Date:   Sat Nov 11 01:19:11 2017 +0900

        Add naming rules

    commit af756cd
    Author: Acid Chicken (硫酸鶏) <root@acid-chicken.com>
    Date:   Sat Nov 11 00:35:30 2017 +0900

        Add basic .NET style rules

    commit 503ece5
    Author: Acid Chicken (硫酸鶏) <root@acid-chicken.com>
    Date:   Fri Nov 10 22:36:52 2017 +0900

        Add EditorConfig

commit 5023357
Author: Christopher F <foxbot@protonmail.com>
Date:   Thu May 24 19:36:33 2018 -0400

    codefix discord-net#1020: RequestOptions should always be sorted last

commit bf5275e
Author: Joe4evr <jii.geugten@gmail.com>
Date:   Thu May 24 19:36:00 2018 -0400

    Add ability to specify parameters on channel creation (discord-net#1020)

    commit 07bca5b
    Author: Joe4evr <jii.geugten@gmail.com>
    Date:   Fri Apr 6 09:44:50 2018 +0200

        Add ability to specify parameters on channel creation

commit 0ba8b06
Author: HelpfulStranger999 <helpfulstranger999@gmail.com>
Date:   Thu May 24 19:23:44 2018 -0400

    Makes text parameter of sending messages optional (discord-net#1042)

    commit 114e5b4
    Author: HelpfulStranger999 <helpfulstranger999@gmail.com>
    Date:   Sat Apr 28 19:08:35 2018 -0500

        Fixes lack of default value for tts

    commit 1fd8c70
    Author: HelpfulStranger999 <helpfulstranger999@gmail.com>
    Date:   Sat Apr 28 15:21:11 2018 -0500

        Makes text parameter of sending messages optional

commit 79811d0
Author: HelpfulStranger999 <helpfulstranger999@gmail.com>
Date:   Thu May 24 17:35:38 2018 -0500

    Paginate reactions - solved discord-net#1007 (discord-net#1022)

    * Cleaned up and refactored slightly

    * Resolves discord-net#971

    * Adds support for default avatars and resolves discord-net#971

    * Amendment

    * Final amendment

    * Paginating reactions

    * Amendments based on feedback

    * Further amendment based on review

    * Final(?) amendment

    * Removes default limit and after user id

    * Removes fromUserId; cleans up model creation; replaces function with individual parameters

commit a998302
Author: Still Hsu <341464@gmail.com>
Date:   Tue May 22 10:15:49 2018 +0800

    Add event docs

    - MessageReceived
    - ChannelUpdated/Destroyed/Created

commit dece19d
Merge: fdaa689 e764daf
Author: Still Hsu <341464@gmail.com>
Date:   Mon May 21 11:47:47 2018 +0800

    Merge branch 'dev' into docs/faq-n-patches-offline

commit fdaa689
Author: Still Hsu <341464@gmail.com>
Date:   Wed May 9 06:04:59 2018 +0800

    Add explanation for RunMode

commit ea82c25
Author: Still Hsu <341464@gmail.com>
Date:   Tue May 8 16:30:48 2018 +0800

    Initial proofread of the articles

commit 124f1a2
Merge: 2555721 97c8931
Author: Still Hsu <341464@gmail.com>
Date:   Tue May 8 05:02:01 2018 +0800

    Merge branch 'dev' into docs/faq-n-patches-offline

commit 2555721
Author: Still Hsu <341464@gmail.com>
Date:   Sun May 6 16:11:19 2018 +0800

    Add details to SpotifyGame

commit c7b236d
Author: Still Hsu <341464@gmail.com>
Date:   Sun May 6 15:58:23 2018 +0800

    Add more IGuild docs

commit 1bb06cc
Author: Still Hsu <341464@gmail.com>
Date:   Sun May 6 15:40:31 2018 +0800

    Replace all langword placements with code block

commit ac47d84
Author: Still Hsu <341464@gmail.com>
Date:   Sun May 6 15:22:17 2018 +0800

    Replace langword null to code block null instead

    - Because DocFX sucks at rendering langword

commit 0b15bbc
Author: Still Hsu <341464@gmail.com>
Date:   Sun May 6 15:20:34 2018 +0800

    Add XML docs

commit 65d4e43
Author: Still Hsu <341464@gmail.com>
Date:   Sun May 6 06:57:53 2018 +0800

    Add BaseSocketClient docs

commit 8f64c04
Author: Still Hsu <341464@gmail.com>
Date:   Sun May 6 06:37:55 2018 +0800

    Replace note block

commit d8bb9e7
Author: Still Hsu <341464@gmail.com>
Date:   Sun May 6 06:31:50 2018 +0800

    Add warning for bulk-delete endpoint

commit adae5ff
Author: Still Hsu <341464@gmail.com>
Date:   Sun May 6 06:07:28 2018 +0800

    Fix missing Username prop

commit 3e59197
Author: Still Hsu <341464@gmail.com>
Date:   Sun May 6 06:01:34 2018 +0800

    Add properties examples to overwrite

commit 0ad66f6
Author: Still Hsu <341464@gmail.com>
Date:   Sun May 6 04:55:15 2018 +0800

    Fix minor consistencies & redundant impl

commit 124efdf
Author: Still Hsu <341464@gmail.com>
Date:   Sun May 6 04:40:14 2018 +0800

    XML Docs

commit 3aa5d36
Author: Still Hsu <341464@gmail.com>
Date:   Sat May 5 18:22:46 2018 +0800

    Add 'last modified' plugin

    Source: https://github.com/Still34/DocFx.Plugin.LastModified
    Licensed under MIT License

commit 2014870
Author: Still Hsu <341464@gmail.com>
Date:   Sat May 5 15:57:40 2018 +0800

    Fix letter-casing for files

commit f27d659
Author: Still Hsu <341464@gmail.com>
Date:   Sat May 5 15:50:00 2018 +0800

    Document exposed TypeReaders

commit 5a824a5
Author: Still Hsu <341464@gmail.com>
Date:   Sat May 5 15:44:15 2018 +0800

    Add missing exceptions

commit c2de0c0
Author: Still Hsu <341464@gmail.com>
Date:   Sat May 5 15:40:16 2018 +0800

    Fix seealso for preconditions and add missing descriptions

commit 3a7d7ee
Author: Still Hsu <341464@gmail.com>
Date:   Sat May 5 15:36:22 2018 +0800

    Minor fixes in documentations
    + Fix unescaped '<'
    + Fix typo

commit 45839bd
Author: Still Hsu <341464@gmail.com>
Date:   Sat May 5 15:29:47 2018 +0800

    Add XML Docs

commit 9e62546
Merge: aea0678 bb4bb13
Author: Still Hsu <341464@gmail.com>
Date:   Sat May 5 14:48:13 2018 +0800

    Merge branch 'dev' into docs/faq-n-patches-offline

commit aea0678
Merge: 27dc483 9ddd709
Author: Still Hsu <341464@gmail.com>
Date:   Sat May 5 13:51:07 2018 +0800

    Merge branch 'docs/faq-n-patches-offline' of https://github.com/Still34/Discord.Net into docs/faq-n-patches-offline

commit 27dc483
Author: Still Hsu <341464@gmail.com>
Date:   Sat May 5 13:50:27 2018 +0800

    Add XML Docs

commit baa8beb
Author: Still Hsu <341464@gmail.com>
Date:   Sat May 5 13:49:42 2018 +0800

    Add XML Docs

commit 089f97a
Author: Still Hsu <341464@gmail.com>
Date:   Sat May 5 13:43:04 2018 +0800

    Add details regarding userbot support

commit 9ddd709
Merge: f197174 7cfed7f
Author: Still Hsu <341464@gmail.com>
Date:   Fri May 4 09:37:04 2018 +0800

    Merge branch 'dev' into docs/faq-n-patches-offline

commit f197174
Author: Still Hsu <341464@gmail.com>
Date:   Fri May 4 09:36:53 2018 +0800

    Fix embed docs consistency

commit 157acc4
Author: Still Hsu <341464@gmail.com>
Date:   Thu May 3 23:03:35 2018 +0800

    Add tag examples

commit 57ea571
Author: Still Hsu <341464@gmail.com>
Date:   Thu May 3 22:48:33 2018 +0800

    Fix sample link & add missing pictures

commit 6769c37
Author: Still Hsu <341464@gmail.com>
Date:   Thu May 3 22:39:26 2018 +0800

    Compress some assets & add OAuth2 URL generator

Still34 added a commit to Still34/Discord.Net that referenced this pull request Sep 30, 2018

Squashed commit of the following:
commit 4f15c35b64f9f51d017572dbc59400f1789eeff2
Author: Still Hsu <341464@gmail.com>
Date:   Mon Oct 1 03:44:35 2018 +0800

    Add XMLDocs

commit d9878a0a6780b73f71eb6372dfe2698e01bebc2e
Merge: 481b27d8 de4d4150
Author: Still Hsu <341464@gmail.com>
Date:   Sat Sep 29 14:06:04 2018 +0800

    Merge branch 'dev' into docs/pre-release

commit de4d4150533327d29bfb1200835fff6fcff8f50a
Author: Chris Johnston <chris@thejohnstons.net>
Date:   Fri Sep 28 18:46:05 2018 -0700

    Fix deploy conditions in CI script (#1157)

    * Fix deploy conditions in CI script

    The deploy conditions had been using a powershell-only variable, and not a environment variable. This meant that the deployment failed on both Windows and Linux (expected only on Linux).

    * Remove an extra newline

    * Remove Debug statements from appveyor build script

commit c898325e4594c7b0ea6455c715903c775ec42a2a
Author: Paulo <pnmanjos@hotmail.com>
Date:   Fri Sep 28 19:22:48 2018 -0300

    Fix GetReactionUsersAsync (#1151)

commit efaedac98f306e1d855f6dc6f9efb5dd99eeb554
Author: Still Hsu <341464@gmail.com>
Date:   Sat Sep 29 06:20:38 2018 +0800

    docs: Fix for incomplete structure sample (#1145)

commit 674a0fc5dd5181e05e32125f63117b2a1a197344
Author: Chris Johnston <chris@thejohnstons.net>
Date:   Fri Sep 28 15:19:00 2018 -0700

    Add Ubuntu target to AppVeyor CI build (#1149)

    * Target Ubuntu in Appveyor CI build

    AppVeyor has released support for targetting Ubuntu 18.04 environments.
    This adds Ubuntu to the list of build images for Appveyor to use.

    * Set clone folder to use appveyor defaults

    * Check if appveyor provides appveyor-retry by trying to run it

    * Minor syntax change

    * Minor syntax change

    * Skip using appveyor-retry (for now)

    * Use forward slash for paths so that it works on both windows and linux

    * Implement replacement for appveyor-retry

    * Script cleanup

    * Remove commented out line

    * Only package releases on Windows

    * Add the isWindows condition to the deploy stage

commit 481b27d884f1fda2cc25e9ee29349e243d94ca0d
Author: Still Hsu <341464@gmail.com>
Date:   Sun Sep 23 14:04:05 2018 +0800

    Add CreateTextChannel sample

commit 08ad210ff5e8541ccd3e28bf24016bbbba6881b4
Author: Still Hsu <341464@gmail.com>
Date:   Sun Sep 23 14:03:10 2018 +0800

    Add an additional note about cross-guild emote usage

commit 936cccf9bcb86f3d918d00dbceb031bc2965d21a
Author: Still Hsu <341464@gmail.com>
Date:   Wed Sep 12 17:11:42 2018 +0800

    Cleanup slow-mode-related documentation strings

commit a08f083775af709fe4b2cc2378816b8f1ca54aec
Merge: c7ef53fe 232f525b
Author: Still Hsu <341464@gmail.com>
Date:   Wed Sep 12 16:53:03 2018 +0800

    Merge branch 'dev' into docs/pre-release

commit 232f525b59e801332ec9dca755366944c79afa1d
Author: Christopher F <foxbot@protonmail.com>
Date:   Tue Sep 11 18:28:31 2018 -0400

    lint: refactor SlowMode -> SlowModeInterval

    this was the name change i always wanted

commit 97d17cfdda22a04173b63247c646acc7cd1122a7
Author: Christopher F <foxbot@protonmail.com>
Date:   Tue Sep 11 18:21:22 2018 -0400

    api: add slow mode

    This adds the following property to ITextChannel
    - SlowMode (int)

    The SlowMode field defines the time in seconds users must wait between
    sending messages; if zero, slow-mode is disabled.

    Bots are not affected by slow-mode, and as such, no changes need to be
    made to the REST client's internal ratelimiting. This is strictly a
    read/write cosmetic property for bots.

commit c7ef53fe6e5dc541752a5c3b9c20be138ec257d2
Author: Still Hsu <341464@gmail.com>
Date:   Tue Sep 11 02:50:35 2018 +0800

    Remove RPC-related notes

commit 8548fbc9a045810bf4f53fe90ef2dcce3997fd96
Author: Still Hsu <341464@gmail.com>
Date:   Tue Sep 11 02:50:14 2018 +0800

    Cleanup several articles to be more human-friendly and easier to read

commit 16b1901d222f60350df33fbeca44407efe71b283
Author: Still Hsu <341464@gmail.com>
Date:   Mon Sep 10 22:24:14 2018 +0800

    Add indentation to example for clarity

commit 1e40e019f40b9ee89d33fbd6d86e16985208bc6a
Author: Still Hsu <341464@gmail.com>
Date:   Mon Sep 10 22:13:40 2018 +0800

    Add additional clarification for installing packages

commit a6780b73af4752c9247d7f2862fc868b16673798
Author: Still Hsu <341464@gmail.com>
Date:   Mon Sep 10 22:12:59 2018 +0800

    Add missing highlighting css for the light theme

commit 8760943b60b59cb1478889dd42db11beb34a482c
Author: Still Hsu <341464@gmail.com>
Date:   Mon Sep 10 21:39:17 2018 +0800

    Fix missing namespace

commit 4197f8b2379e149e630c9512008af2a7e18f3867
Author: Still Hsu <341464@gmail.com>
Date:   Mon Sep 10 20:08:00 2018 +0800

    Cleanup https://github.com/RogueException/Discord.Net/pull/1139

commit 23ed0ec61a2dfd1c8329be492ed23122cea4739c
Merge: 7bed4a0b 9e9a11d4
Author: Still Hsu <341464@gmail.com>
Date:   Mon Sep 10 20:02:52 2018 +0800

    Merge branch 'dev' into docs/pre-release

commit 9e9a11d4b09362aadac6d32be0ac83fdddc5e19e
Author: Chris Johnston <chris@thejohnstons.net>
Date:   Thu Sep 6 19:08:45 2018 -0700

    Fix swapped parameters in ArgumentException, ArgumentNullException cstrs (#1139)

    * Fix swapped parameters in ArgumentException and ArgumentNullException cstrs

    The constructors of ArgumentException and ArgumentNullException are inconsistent with each other, which results in their parameters being swapped here and there.

    * Use named parameters for ArgumentException constructors

    Cleans up some of the methods of EmbedBuilder to use simpler syntax as well

commit 7bed4a0b31d4dae7bc0ccec165681045b5aa2912
Author: Still Hsu <341464@gmail.com>
Date:   Thu Sep 6 05:13:36 2018 +0800

    Cleanup FAQ section
    + Add introductory paragraphs to each FAQ section.
    + Add 'missing dependency' entry to commands FAQ.
    * Split commands FAQ to 'General' and 'DI' sections.

commit ca7318c0e5cd08b6bee08b8ee6f6786e7e77c154
Author: Still Hsu <341464@gmail.com>
Date:   Wed Sep 5 05:45:49 2018 +0800

    Fix broken xref

commit 63fe6648062cd170c30e0eacb512d70abd6cb133
Author: Still Hsu <341464@gmail.com>
Date:   Wed Sep 5 05:45:35 2018 +0800

    Fix navbar collapsing issue

commit 0668b7d0b3a3daddf1e11e3bfa7a5255f49bb984
Author: Still Hsu <341464@gmail.com>
Date:   Wed Sep 5 02:50:25 2018 +0800

    Update docfx plugins

commit 1a9d4b6cb956d94f55b8d38e92bda4236a0b385a
Author: Still Hsu <341464@gmail.com>
Date:   Wed Sep 5 02:34:53 2018 +0800

    Add XML docs

commit 314a1a29a1cae1bc55e0d1b69af0664ef5428d8d
Author: Still Hsu <341464@gmail.com>
Date:   Wed Sep 5 02:34:34 2018 +0800

    Cleanup FAQ structure

commit a89c27c34138146530a438f93f807cc647636660
Author: Still Hsu <341464@gmail.com>
Date:   Fri Aug 31 16:43:40 2018 +0800

    Fix first bot note

commit bf35369fe9e5c465e3671bd947495a764708abc6
Author: Still Hsu <341464@gmail.com>
Date:   Fri Aug 31 16:31:20 2018 +0800

    Cleanup https://github.com/RogueException/Discord.Net/pull/1128

commit afcae02755a16eb83110e7799c3b67bec9694557
Author: Still Hsu <341464@gmail.com>
Date:   Fri Aug 31 16:25:48 2018 +0800

    Add examples in message methods

commit 591a5c7a3c3c87698e17a05dc9bff5b1b07506fd
Author: Still Hsu <341464@gmail.com>
Date:   Fri Aug 31 15:39:55 2018 +0800

    Initial optimization for DocFX render & add missing files

commit e6280ceec5864b7396fc35c1c9811afecb9ed462
Author: Still Hsu <341464@gmail.com>
Date:   Fri Aug 31 13:05:02 2018 +0800

    Update 'Your First Bot'
    + This commit reflects the new changes made to the Discord Application Developer Portal after its major update

commit 112fe7237437c492fe5c7efe77d3473f6a6078e8
Merge: 6d355ed1 272604f2
Author: Still Hsu <341464@gmail.com>
Date:   Fri Aug 31 11:30:49 2018 +0800

    Merge branch 'dev' into docs/pre-release

commit 6d355ed125c79a52a97991aac5117ef30236bb03
Author: Still Hsu <341464@gmail.com>
Date:   Fri Aug 31 11:19:18 2018 +0800

    Add XML docs & rewrite GetMessagesAsync docs

    This commit rewrites the remarks section of GetMessagesAsync, as well as adding examples to several methods.

commit ec97895c41caa9c820713e899eff5395f1275c44
Author: Still Hsu <341464@gmail.com>
Date:   Fri Aug 31 11:18:15 2018 +0800

    Fix lots of typos in comments
    + Geez, I didn't know there were so many.

commit 90fdd54926324dad92005a3c60681a186c00950d
Author: Still Hsu <341464@gmail.com>
Date:   Fri Aug 31 09:27:18 2018 +0800

    Add XML docs

commit 142d28ee5fc4bb1f63a949fe0ebdbd09e473ff15
Author: Still Hsu <341464@gmail.com>
Date:   Fri Aug 31 09:27:02 2018 +0800

    Add strings for dictionary in DotSettings

commit 171dd1f51eaedcf78484686acdf8f67d555aa8f4
Author: Still Hsu <341464@gmail.com>
Date:   Fri Aug 31 09:25:20 2018 +0800

    Fix for misleading behaviour in the emoji guide
    + Original lines stated that sending a emoji wrapped in colon will not be parsed, but that was incorrect; replaced with reactions instead of sending messages as the example

commit 272604f27578dba67de8039e4e88901a26299883
Author: Alex Gravely <tcbskater@hotmail.com>
Date:   Thu Aug 30 17:38:44 2018 -0400

    Make voice connection properties optional. (#1129)

commit 82cfdffc6516e17ea86013e550060bb6df59a016
Author: Still Hsu <341464@gmail.com>
Date:   Fri Aug 31 05:36:44 2018 +0800

    Add various optimizations and cleanups (#1114)

    * Change all Select(... as ...) to OfType

    * Add changes according to https://github.com/Still34/Discord.Net/commit/194a8aa4273caa4ea6723e6fab4d8b3f9efc0a00

commit a2d8800115c7cc41d82871a68cd08fcdecc747ab
Author: Joe4evr <jii.geugten@gmail.com>
Date:   Thu Aug 30 23:29:05 2018 +0200

    Add == support on Color (#1126)

commit 2de6cef18c495aaa0cb70b1496ea528b47337fd2
Author: Chris Johnston <chris@thejohnstons.net>
Date:   Thu Aug 30 14:27:37 2018 -0700

    Add validation to bot tokens based on string length (#1128)

    * Add input validation for bot tokens based on their length

    * Add token validation to BaseDiscordClient#LoginAsync

    Adds a TokenUtils class which is used to validate that tokens are correct

    * Revert changes to DiscordRestApiClient

    * Add Unit tests to the TokenUtils class, fix a logic error that was caught by those tests

    * Allow for API to throw exceptions

    Moves the validation of tokens to be inside of LoginInternalAsync, and writes a Warning to the console when the supplied tokens are invalid

commit e0a321a3f1a521330ec223edf94c642961bfb187
Merge: e7f63586 efdb4f92
Author: Still Hsu <341464@gmail.com>
Date:   Fri Aug 31 03:31:07 2018 +0800

    Merge branch 'dev' into docs/pre-release

commit efdb4f926698bbf6ef2d93779291f7f39d675b3f
Author: Finite Reality <FiniteReality@users.noreply.github.com>
Date:   Wed Aug 29 17:11:26 2018 +0100

    Pass our json serializer to ToObject calls (#1133)

    Should fix issues in audit logs when deserializing overwrites and
    similar types which we use a custom contract resolver for.

commit 143fb2808bcf034a1cbb4231fc19424972a22ca4
Author: JustNrik <35231903+JustNrik@users.noreply.github.com>
Date:   Mon Aug 27 17:39:00 2018 -0400

    Update CommandAttribute.cs

commit c56fff9fe55648cdb09325bf95bd244a125f0adc
Author: JustNrik <35231903+JustNrik@users.noreply.github.com>
Date:   Mon Aug 27 00:44:35 2018 -0400

    Update CommandAttribute.cs

commit 4259b8cb0cfb63e66cde9d0f2c3e7de5a59971ab
Author: JustNrik <35231903+JustNrik@users.noreply.github.com>
Date:   Mon Aug 27 00:11:55 2018 -0400

    Update CommandAttribute.cs

    Nullable<T> is not valid for Attributes, this is my suggested fix.

commit db90eab9534967a9b4a43436991711a372aec320
Author: Still Hsu <341464@gmail.com>
Date:   Tue Aug 21 06:27:50 2018 +0800

    Update README.md (#1117)

    * Initial commit

    * Add alternative suggestion

    * Fix typo

    * Update README.md

commit e7f63586fecb5fbe0e2c75b73a479ced673216a4
Author: Still Hsu <341464@gmail.com>
Date:   Wed Aug 15 00:46:39 2018 +0800

    Cleanup previous PR

commit 9cc4f134563f97768baf99c30b74793f8f88bb94
Author: Still Hsu <341464@gmail.com>
Date:   Sat Aug 11 02:59:29 2018 +0800

    Cleanup of https://github.com/Still34/Discord.Net/pull/8

commit 8a0429d4f883e2a219f6f17e4d1d26265239d224
Author: Still Hsu <341464@gmail.com>
Date:   Sat Aug 11 02:53:29 2018 +0800

    Update DescriptionGenerator

commit ab2742ea518d11bab2cef0eb38e1e720ef572ddf
Merge: ae090fb3 3ad948d4
Author: Still Hsu <341464@gmail.com>
Date:   Fri Aug 10 22:33:12 2018 +0800

    Merge pull request #8 from Chris-Johnston/add-misc-missing-docs

    Added some miscellaneous missing xmldocs

commit 3ad948d44b52c640c11e776b1eaf64cb394c7db2
Author: Chris Johnston <chris@thejohnstons.net>
Date:   Fri Aug 10 07:21:07 2018 -0700

    Fix grammar issue

commit ae090fb3162b681f89634626501cfacf53860e80
Merge: 54e5a6f2 748e92bc
Author: Still Hsu <341464@gmail.com>
Date:   Fri Aug 10 21:13:45 2018 +0800

    Merge branch 'dev' into docs/pre-release

commit 54e5a6f261d8acc93c19c7a373c0dfd76581a541
Merge: 10c412c0 a63d4690
Author: Still Hsu <341464@gmail.com>
Date:   Fri Aug 10 21:04:35 2018 +0800

    Merge pull request #10 from CasinoBoyale/030818-Branch

    Added some class summaries

commit 6e80cef06e2835bd6f7ec084e66e6fe53fc40d95
Author: Chris Johnston <chris@thejohnstons.net>
Date:   Thu Aug 9 21:36:10 2018 -0700

    Add <remarks> tag to the IGuildIntegration xmldocs

commit cee15227b2cf34e4849ea5465dfdf6597008bc0e
Author: Chris Johnston <chris@thejohnstons.net>
Date:   Thu Aug 9 21:22:36 2018 -0700

    Use consistent quotation marks around subscribers, the name for these users are dependant on the source of where they are integrated from (youtube or twitch), so we should not use a name that is specific to one platform

commit 25c208cccda31a986191495a23a53debc102d494
Author: Chris Johnston <chris@thejohnstons.net>
Date:   Thu Aug 9 21:07:31 2018 -0700

    Removed unnecessary see tag

commit e41136c955de998f4fa6ea66d3d4be3d2414991c
Author: Chris Johnston <chris@thejohnstons.net>
Date:   Thu Aug 9 21:06:44 2018 -0700

    restored the removed line break

commit 748e92bcda7410f6a0891b33f15fd7b77fb93a24
Author: Joe4evr <jii.geugten@gmail.com>
Date:   Thu Aug 9 02:20:36 2018 +0200

    Allow `FromError(Exception)` on all IResult types.

commit 2c3e9193c29c31a6822a24d7d574d6f827e95805
Author: Joe4evr <jii.geugten@gmail.com>
Date:   Thu Aug 9 18:26:38 2018 +0200

    Implement ISnowflakeEntity for Audit Log entries

commit a63d46908c9f014b8cecdcf081848a936b45aa25
Author: Casino Boyale <kayrenhi@gmail.com>
Date:   Thu Aug 9 17:19:31 2018 +0100

    Amendments

commit 10c412c0fdd3dcb9df58c040fdf8deb2116e3720
Merge: 35fd4eb4 a139e945
Author: Still Hsu <341464@gmail.com>
Date:   Thu Aug 9 23:56:46 2018 +0800

    Merge pull request #9 from Joe4evr/TwoReactionSample

    Added second sample for adding reactions

commit 0b2dbffe88e5279ccf94ac81a4b384a3229af9bc
Author: Casino Boyale <kayrenhi@gmail.com>
Date:   Thu Aug 9 01:11:40 2018 +0100

    Missed a period

commit 2f41896cdf2c1666842322497705ed79c19612c8
Author: Casino Boyale <kayrenhi@gmail.com>
Date:   Thu Aug 9 01:08:18 2018 +0100

    Added some class summaries

commit a139e945764d80f2790a4a8342d03dd8a226457d
Author: Joe4evr <jii.geugten@gmail.com>
Date:   Sat Aug 4 18:52:07 2018 +0200

    Added second sample for adding reactions

commit d9e186467e1cda3bbce3b3cd4106121e2cf6e760
Author: Chris Johnston <chris@thejohnstons.net>
Date:   Thu Aug 2 14:20:51 2018 -0700

    Added types to <returns> tags where missing

commit 35fd4eb45e754e168ccc833c81165b561e362484
Author: Still Hsu <341464@gmail.com>
Date:   Thu Aug 2 23:45:39 2018 +0800

    Cleanup doc for c1d78189

commit 3876bd79e6d858f7d7708e9f2094361e84e813c0
Merge: d00e3360 c1d78189
Author: Still Hsu <341464@gmail.com>
Date:   Thu Aug 2 23:43:26 2018 +0800

    Merge branch 'dev' into docs/pre-release

commit d00e3360fedc255a01facc1eb70d6656997c18b6
Merge: a1ee83b1 0fd59f88
Author: Still Hsu <341464@gmail.com>
Date:   Thu Aug 2 23:39:28 2018 +0800

    Merge pull request #7 from CasinoBoyale/Casino-Docs

    Added some REST documentation

commit c1d78189e11969c4ff9054bcd29323a3ffef7a54
Author: Christopher F <foxbot@protonmail.com>
Date:   Wed Aug 1 15:09:46 2018 -0400

    core: add PrioritySpeaker to Permissions

commit 5dad0fa1a1f40c104cec86dde6d1c10a3025d915
Author: Joe4evr <jii.geugten@gmail.com>
Date:   Wed Aug 1 16:10:21 2018 +0200

    Minor fixes around OnModuleBuilding (#1116)

    * Don't attempt instantiation of an abstract module
    * Attempt associating a TypeReader in case one is registered late (ie. OnModuleBuilding)

commit 0fd59f8840f596755a142725a72a6aa1530cfc7d
Author: Casino Boyale <kayrenhi@gmail.com>
Date:   Wed Aug 1 13:32:42 2018 +0100

    Amendments

commit 1d20132104d9ffd8ab871e245766160b36b882de
Author: Chris Johnston <githubchrisjohnston@gmail.com>
Date:   Tue Jul 31 22:58:48 2018 -0700

    Rewrote the rest of the returns tags

commit c8bc452c68a7fc94e594b7be5b168e0549f96cfd
Author: Chris Johnston <githubchrisjohnston@gmail.com>
Date:   Tue Jul 31 22:52:27 2018 -0700

    Rewrote the returns tags in IGuildIntegration, removed the ones I was unsure about.

commit a1ee83b1dc41b742b4c583d78ae30f01a0cb7999
Author: Still Hsu <341464@gmail.com>
Date:   Wed Aug 1 13:15:25 2018 +0800

    Add XML docs

commit cbad425a3320fc562989fd0d47bfb40043fdd0e3
Author: Still Hsu <341464@gmail.com>
Date:   Wed Aug 1 13:14:51 2018 +0800

    Change all color class references to struct
    ...because it isn't a class.

commit 9bbf5805426623902f691ef2b7e44d1240cef9dc
Author: Chris Johnston <githubchrisjohnston@gmail.com>
Date:   Mon Jul 30 22:48:48 2018 -0700

    Added property get pattern to xml docs and identical returns tag.

commit 9185853db1d3ed753833ec21dea7f92c52e20c32
Author: Chris Johnston <githubchrisjohnston@gmail.com>
Date:   Mon Jul 30 22:43:16 2018 -0700

    Added property get standard for IntegrationAccount

commit 3d8e08219b28d1dc9cfe4eac8c2379fc38ba575a
Author: Chris Johnston <githubchrisjohnston@gmail.com>
Date:   Mon Jul 30 22:41:05 2018 -0700

    Made changes to get field descriptions from feedback, added returns tag to IConnection

commit a46910ced77c1937d5a6311e86b08b8b3eff2b43
Author: Chris Johnston <githubchrisjohnston@gmail.com>
Date:   Mon Jul 30 22:19:32 2018 -0700

    fix spacing of values in guildpermission

commit 9fcea887f0c79899733fad3394d88b789c036f7e
Author: Chris Johnston <chris@thejohnstons.net>
Date:   Mon Jul 30 22:17:01 2018 -0700

    Fix whitespace in ChannelPermission

commit 981e2eb18f1991a8dbc26a82ba34d3990aafc9cc
Author: Chris Johnston <githubchrisjohnston@gmail.com>
Date:   Mon Jul 30 22:10:57 2018 -0700

    I can spell :^)

commit c572a98dc73dcfc9697b5668f7d90f743c765981
Author: Chris Johnston <githubchrisjohnston@gmail.com>
Date:   Mon Jul 30 22:06:10 2018 -0700

    Added discord API documentation to IConnection interface

commit e8b3b493b0f20e6f93fe1fd1dab2d36e07e717be
Author: Chris Johnston <githubchrisjohnston@gmail.com>
Date:   Mon Jul 30 22:03:54 2018 -0700

    Added specification of how the bits of the color raw value are packed

commit 14b645a29be5c97b8098640591627ea997345e1d
Author: Chris Johnston <githubchrisjohnston@gmail.com>
Date:   Mon Jul 30 22:00:25 2018 -0700

    Added xml doc for ToAllowList and ToDenyList

commit 677e7153529554089917a39acaf8d6303b6e44e9
Author: Chris Johnston <githubchrisjohnston@gmail.com>
Date:   Mon Jul 30 21:58:05 2018 -0700

    Added xmldoc for GuildPermission methods

commit d64f670f2b224eaf9945a022684d40c0e8d36287
Author: Chris Johnston <githubchrisjohnston@gmail.com>
Date:   Mon Jul 30 21:54:23 2018 -0700

    Added remarks about 2FA requirement for guild permissions

commit 6c3f85db7e7ec363a4a5f01a44cd89b13a3a4434
Author: Chris Johnston <githubchrisjohnston@gmail.com>
Date:   Mon Jul 30 21:51:31 2018 -0700

    Added obsolete mention to the ReadMessages flag.

commit 8dc6f2efad96017d14ec0ea562819ab310ac03f0
Author: Chris Johnston <githubchrisjohnston@gmail.com>
Date:   Mon Jul 30 21:42:23 2018 -0700

    Added minimal descriptions from the API documentation for Integration types

commit 4d3d2dcb387b8d03e1a1a63783076e39df826a37
Author: Casino Boyale <kayrenhi@gmail.com>
Date:   Tue Jul 31 00:36:18 2018 +0100

    Adjustment to SocketDMChannel

commit e823fc2333581080eef3c79d9faf88ad651f8ca7
Author: Casino Boyale <kayrenhi@gmail.com>
Date:   Tue Jul 31 00:31:23 2018 +0100

    Added RestGuild documentation

commit 17847e95e21ea4bd2c3402c24f949fa03198d734
Author: Casino Boyale <kayrenhi@gmail.com>
Date:   Tue Jul 31 00:14:35 2018 +0100

    Added RestDMChannel documentation

commit c623b828a6e73f5aa15e376236089b5b29658708
Author: Casino Boyale <kayrenhi@gmail.com>
Date:   Tue Jul 31 00:14:23 2018 +0100

    Added SocketDMChannel documentation

commit ba8515a5d3d2c3933ad34a071b934bb2eaf272be
Author: Casino Boyale <kayrenhi@gmail.com>
Date:   Tue Jul 31 00:04:45 2018 +0100

    Amendments to RestUser

commit 09ccc5033bc48391ddf668a6b8f9aa86362ae9bd
Author: Still Hsu <341464@gmail.com>
Date:   Thu Jul 26 10:19:07 2018 +0800

    Rollback font optimization changes

commit af8c289997124a6ca90c870953c0edfc79a1b962
Author: Still Hsu <341464@gmail.com>
Date:   Thu Jul 26 10:09:00 2018 +0800

    Minor optimization for doc rendering

commit 3ef78a90e0cabe58c7ec4a8aaf76fd5dbc532fd7
Author: Still Hsu <341464@gmail.com>
Date:   Sat Jul 21 12:42:25 2018 +0800

    Add XML docs & minor optimizations

commit d9321d160e1dad9ca5e0eff4f40b4ba8cc821406
Merge: 050872db afc3a9d0
Author: Still Hsu <341464@gmail.com>
Date:   Sat Jul 21 12:11:56 2018 +0800

    Merge branch 'dev' into docs/pre-release

commit afc3a9d0636598e6638a06781b86f48bac5c5376
Author: Casino Boyale <kayrenhi@gmail.com>
Date:   Sat Jul 21 01:31:30 2018 +0100

    Added GetJumpUrl() as an extension method for IMessage (#1102)

    * Added GetJumpUrl() as an IMessage extension method

    * Removed extra line for consistency

    * Moved the namespace from Discord.Commands to Discord

    * lint: remove eof newline

    * lint: use TextChannel to get GuildID

commit aadd6f639f7cdfa0abc9133eb279c88fa22144cf
Author: Finite Reality <FiniteReality@users.noreply.github.com>
Date:   Sat Jul 21 01:07:29 2018 +0100

    Add missing fields to new MemberInfo type (#1107)

commit a282cfd21737f20f1159c8d353c0b58aafc0cff5
Author: Casino Boyale <kayrenhi@gmail.com>
Date:   Mon Jul 16 16:45:37 2018 +0100

    Added RestInvite documentation

commit afb007fd09cba32b97beb211fae5c1c0cef8e53c
Author: Casino Boyale <kayrenhi@gmail.com>
Date:   Mon Jul 16 16:43:54 2018 +0100

    Added RestUser Documentation

commit 5a517da91942362a1b8135ce048797f67ed7c3ad
Author: Casino Boyale <kayrenhi@gmail.com>
Date:   Mon Jul 16 12:41:18 2018 +0100

    Fixed a typo in ISnowflakeEntity

commit 050872db598fda4fac2789e8f64391b1d18c1360
Author: Still Hsu <341464@gmail.com>
Date:   Sun Jul 15 13:59:12 2018 +0800

    Clarify supported nullable type

commit 0ffe27180291d3d383e1c22d126a6bed33ae1c6b
Author: Still Hsu <341464@gmail.com>
Date:   Sun Jul 15 13:46:59 2018 +0800

    Fix arrow alignment

commit 535746fb20f42f803c4739d11fb9a8e78dd958a5
Author: Still Hsu <341464@gmail.com>
Date:   Sat Jul 14 02:55:45 2018 +0800

    Add XML docs

commit fb46f9a5672c57863823c49e38e73ff4461ade9b
Merge: 156039e5 b27051bf
Author: Still Hsu <341464@gmail.com>
Date:   Fri Jul 13 15:55:21 2018 +0800

    Merge pull request #5 from sarcasmloading/docs/pre-release

    Documented remaining audit log data types

commit b27051bfb1dfaf15b1ad00683a22b5991f6a629f
Author: sarcasmloading <29299928+sarcasmloading@users.noreply.github.com>
Date:   Fri Jul 13 19:45:40 2018 +1200

    [EN] Present perf. -> past perf.

commit 156039e5a005c66896d3d637aaa3f98f6d90b700
Merge: aa7d12d3 783205bc
Author: Still Hsu <341464@gmail.com>
Date:   Fri Jul 13 15:34:35 2018 +0800

    Merge branch 'docs/pre-release' of https://github.com/Still34/Discord.Net into docs/pre-release

commit 783205bcb76d7141e1ef7a839c65cb1a9604c5cf
Merge: 9c76e7e8 bcb48a63
Author: Still Hsu <341464@gmail.com>
Date:   Fri Jul 13 15:34:13 2018 +0800

    Merge pull request #4 from CasinoBoyale/docs/pre-release

    Added documentation for SocketDMChannel, SocketGuildChannel, and SocketTextChannel

commit cb35aa2b676007605ff7c00db77f7248b93bfd21
Author: sarcasmloading <29299928+sarcasmloading@users.noreply.github.com>
Date:   Fri Jul 13 19:34:08 2018 +1200

    Contains -> Contains a piece of (describe article)

commit 9c76e7e81df248eaa2437c5a4b60c50f05e24d9b
Merge: 199bcd6b ef07d73e
Author: Still Hsu <341464@gmail.com>
Date:   Fri Jul 13 15:33:00 2018 +0800

    Alter parameter naming (#6)

    Slightly better wording

commit aa7d12d32b38ebc3975d320ec7c40fa5ad4f5a45
Merge: 199bcd6b 245806fe
Author: Still Hsu <341464@gmail.com>
Date:   Fri Jul 13 15:16:17 2018 +0800

    Merge remote-tracking branch 'upstream/dev' into docs/pre-release

commit ef07d73e6e87f3d027a229290f8ee592bf22acaa
Author: Joe4evr <jii.geugten@gmail.com>
Date:   Fri Jul 13 08:58:03 2018 +0200

    Slightly better wording

commit bcb48a63b29229537081ca36152717077567292a
Merge: 6e416922 bd51b9bd
Author: Casino Boyale <kayrenhi@gmail.com>
Date:   Thu Jul 12 02:38:15 2018 +0100

    Merge pull request #1 from CasinoBoyale/Casino-Docs

    Added documentation

commit bd51b9bdb2af950efcbd5e539d95cf7645094a72
Author: Casino Boyale <kayrenhi@gmail.com>
Date:   Thu Jul 12 02:33:16 2018 +0100

    Added RestMessage documentation

commit 09cd5b8ded20c78484ee89b031154e71ae6ec7ca
Author: Casino Boyale <kayrenhi@gmail.com>
Date:   Thu Jul 12 02:26:50 2018 +0100

    Added RestRole documentation

commit 1789a8158c7748fc2fe1d9164051ed7465925923
Author: Casino Boyale <kayrenhi@gmail.com>
Date:   Thu Jul 12 02:25:18 2018 +0100

    Added RestUser documentation

commit c9ef0e26e23f3cba5eb66bbaa8b0301d2d33945c
Author: Casino Boyale <kayrenhi@gmail.com>
Date:   Thu Jul 12 02:22:38 2018 +0100

    Added RestVoiceChannel documentation

commit 44c526298e03cd71c9454378b26349b360503410
Author: Casino Boyale <kayrenhi@gmail.com>
Date:   Thu Jul 12 02:22:18 2018 +0100

    Added RestTextChannel documentation

commit 908f29b5486c3d3a9b835053de38a44c9d2e1cc1
Author: Casino Boyale <kayrenhi@gmail.com>
Date:   Thu Jul 12 02:06:45 2018 +0100

    Added RestGuildChannel documentation

commit b40ab464cce8f9c1b009bd08638e4297bcc952e3
Author: Casino Boyale <kayrenhi@gmail.com>
Date:   Thu Jul 12 01:58:47 2018 +0100

    Added RestDMChannel documentation

commit 245806fe3da063b8d11c26ae3ea7723daab83797
Author: Still Hsu <341464@gmail.com>
Date:   Thu Jul 12 08:44:00 2018 +0800

    Initial refactor (#1103)

commit 1f4718e60ce00d93d51813f508071eaf8f82fca7
Merge: d4598bac 199bcd6b
Author: sarcasmloading <29299928+sarcasmloading@users.noreply.github.com>
Date:   Thu Jul 12 12:37:16 2018 +1200

    Merge branch 'docs/pre-release' of https://github.com/Still34/Discord.Net into docs/pre-release

    Merge remote upstream

commit 6e41692261666ecba74b16310d826345aa2d44db
Merge: 32c9d0e2 199bcd6b
Author: Casino Boyale <kayrenhi@gmail.com>
Date:   Thu Jul 12 01:33:45 2018 +0100

    Merge remote-tracking branch 'upstream/docs/pre-release' into docs/Casino-Docs

commit d4598bac11ff88385a324309b8ef3df8cc4b5c93
Author: sarcasmloading <29299928+sarcasmloading@users.noreply.github.com>
Date:   Thu Jul 12 12:13:53 2018 +1200

    Document remaining audit log data types

commit 812399a42ce795e7b18880376c67546e729006bf
Author: sarcasmloading <29299928+sarcasmloading@users.noreply.github.com>
Date:   Thu Jul 12 11:34:54 2018 +1200

    Documented RoleCreateAuditLogData

commit 541b473d59f9dbb2b9171c81960658383243b20a
Author: sarcasmloading <29299928+sarcasmloading@users.noreply.github.com>
Date:   Wed Jul 11 23:00:35 2018 +1200

    Documented two more types

commit 199bcd6b26f3ffc8561a9570121a9e1ec0236a1b
Author: Still Hsu <341464@gmail.com>
Date:   Wed Jul 11 18:48:54 2018 +0800

    Add XML doc

commit d11693eb6f5328ad3cded6e953a8775aa692ca3e
Merge: b940ecb9 b2f00439
Author: Still Hsu <341464@gmail.com>
Date:   Wed Jul 11 18:47:07 2018 +0800

    Merge branch 'dev' into docs/pre-release

commit ac96af34314fdcf175f9090e72c3dca583558e10
Author: sarcasmloading <29299928+sarcasmloading@users.noreply.github.com>
Date:   Wed Jul 11 22:20:28 2018 +1200

    Fix English posession

commit 580d30fcb502ee98e03a7a0c6e491bcf39b805da
Author: sarcasmloading <29299928+sarcasmloading@users.noreply.github.com>
Date:   Wed Jul 11 22:19:24 2018 +1200

    Fix some documentation issues and document some more audit log data types

commit 060bf1fc917e87c73d21cf6b670a9563a9cbd04d
Author: sarcasmloading <29299928+sarcasmloading@users.noreply.github.com>
Date:   Wed Jul 11 21:53:53 2018 +1200

    Change audit log data types to start with 'Contains' (verb) instead of an article

commit e85fca6b45729c8ff64c30c8c91c50e57891f98a
Author: sarcasmloading <29299928+sarcasmloading@users.noreply.github.com>
Date:   Wed Jul 11 21:42:13 2018 +1200

    Added documentation for many audit log data types, fixed vowel indefinite articles

commit b2f00439524af9836818631f4bfa7c42e9076feb
Author: Still Hsu <341464@gmail.com>
Date:   Wed Jul 11 07:32:29 2018 +0800

    Fix typo in audit log interface declaration (#1104)

commit b940ecb95e221659c2af920327d692aaf654bceb
Author: Still Hsu <341464@gmail.com>
Date:   Wed Jul 11 06:29:11 2018 +0800

    Add XML docs & patch return types
    + Starting from this commit, all return types for tasks will use style similar to most documentations featured on docs.microsoft.com

    References:
    https://docs.microsoft.com/en-us/dotnet/api/microsoft.entityframeworkcore.dbcontext.-ctor?view=efcore-2.1
    https://docs.microsoft.com/en-us/dotnet/api/system.io.filestream.readasync?view=netcore-2.1
    https://docs.microsoft.com/en-us/dotnet/api/system.io.textwriter.writelineasync?view=netcore-2.1#System_IO_TextWriter_WriteLineAsync_System_Char___
    And many more other asynchronous method documentations featured in the latest BCL.

commit 32c9d0e2dd5d06c75277a77e108bb22c73c00c1a
Author: Casino Boyale <kayrenhi@gmail.com>
Date:   Tue Jul 10 21:08:17 2018 +0100

    SocketTextChannel amendments

commit 0a149eb420054a9fa33e7bd2594824fbe337754c
Author: Casino Boyale <kayrenhi@gmail.com>
Date:   Tue Jul 10 21:05:51 2018 +0100

    SocketGuildChannel amendments

commit 5346defe84d1f5394a8539be6da4117558c06bd0
Author: Casino Boyale <kayrenhi@gmail.com>
Date:   Tue Jul 10 21:01:10 2018 +0100

    SocketDMChannel amendments

commit c0e99adf67bb069d56dd969e3fe50d29f22b8784
Merge: 80b12847 b1c955b8
Author: Casino Boyale <kayrenhi@gmail.com>
Date:   Sat Jul 7 15:56:34 2018 +0100

    Merge remote-tracking branch 'origin/docs/pre-release' into docs/pre-release

commit 80b128479f24db387bf0a88c8760ed99099a84e4
Author: Casino Boyale <kayrenhi@gmail.com>
Date:   Sat Jul 7 15:55:54 2018 +0100

    Swapped out 'id' for 'snowflake identifier'

commit b1c955b8bc38b5ce4646de1f9cf0735fefa9b18e
Author: Casino Boyale <kayrenhi@gmail.com>
Date:   Sat Jul 7 15:55:54 2018 +0100

    Swapped out 'id' for 'snowflake identifier

commit 02ddca1510d9ec8d144d3517088f4ea577d96f3b
Author: Casino Boyale <kayrenhi@gmail.com>
Date:   Sat Jul 7 15:53:04 2018 +0100

    Corrections to SocketDMChannel

commit 4b18759e7da0b961739caef8d49b2a8fe47b9818
Author: Casino Boyale <kayrenhi@gmail.com>
Date:   Sat Jul 7 15:45:49 2018 +0100

    Corrections to SocketTextChannel

commit 3018f8ef427929498be7d852b074b177e21aaff3
Author: Casino Boyale <kayrenhi@gmail.com>
Date:   Sat Jul 7 15:43:54 2018 +0100

    Corrections to SocketGuildChannel

commit 24077c768272e7d43a9c7c8f8307474474e24347
Author: Still Hsu <341464@gmail.com>
Date:   Sat Jul 7 16:02:58 2018 +0800

    Add XML docs

commit 6797b0f0ea89a640f5a37aaca109390be6d174e5
Author: Casino Boyale <kayrenhi@gmail.com>
Date:   Thu Jul 5 14:27:32 2018 +0100

    Added documentation for SocketDMChannel, SocketGuildChannel, and SocketTextChannel

commit 64b5612b193ee589d1381c63d215ff9278c70321
Merge: faef9a9a 7e76fda7
Author: Still Hsu <341464@gmail.com>
Date:   Thu Jul 5 14:26:53 2018 +0800

    Merge branch 'docs/pre-release' of https://github.com/Still34/Discord.Net into docs/pre-release

commit faef9a9a53c965e3d24cefb5efcd1ebf749665dc
Author: Still Hsu <341464@gmail.com>
Date:   Thu Jul 5 14:26:25 2018 +0800

    Fix minor docs

commit 7e76fda733be9cfbff98ab849811926878e59580
Merge: 5b65e4fe beb3d46e
Author: Still Hsu <341464@gmail.com>
Date:   Wed Jul 4 09:36:06 2018 +0800

    Merge remote-tracking branch 'upstream/dev' into docs/pre-release

commit beb3d46e0866c3d1ee8fa8483576547e90b517c6
Author: Christopher F <foxbot@protonmail.com>
Date:   Mon Jul 2 21:24:50 2018 -0400

    gateway: Ignore PRESENCES_REPLACE dispatch

    This dispatch is undocumented and only used by user accounts.

commit ffe994a9dff1ea3bca63673d332a28b88231d38d
Author: Still Hsu <341464@gmail.com>
Date:   Tue Jul 3 05:02:38 2018 +0800

    Mark guild optional in invite & general invite improvement (#1094)

    * Mark guild as optional for invite

    * Mark partial InviteMetadata members as Optional<T>

    * Some of them aren't sent when requesting through the general GET invite endpoint

    * Remove GetInviteParams

    * It was kinda stupid in the first place, might as well always get the count instead of having to ask the user whether they want the two fields filled or not.

    * Add ChannelType property

    * Add vanity invite support

commit 4bc06a0a54477e756caa18d3030e5a8e7fa20d10
Author: HelpfulStranger999 <helpfulstranger999@gmail.com>
Date:   Mon Jul 2 15:29:42 2018 -0500

    Patch lazy default readers not getting replaced (#1083)

commit 5b65e4feb9d9f8c3d84012612b8e5ed9ad4308ed
Author: Still Hsu <341464@gmail.com>
Date:   Wed Jun 27 07:24:06 2018 +0800

    Shift color return docs

commit 9a3aa1bb647bb0026a0308f06504be0d60b1a4a3
Author: Still Hsu <341464@gmail.com>
Date:   Wed Jun 27 07:06:15 2018 +0800

    Add XML documentations

commit 1584aa31f1a6f66363303e598741d2754311ef3d
Author: Still Hsu <341464@gmail.com>
Date:   Tue Jun 26 17:29:20 2018 +0800

    Fix exception summary to comply with official Microsoft Docs style

    * References
    https://docs.microsoft.com/en-us/dotnet/api/system.argumentnullexception?view=netframework-4.7.2
    https://docs.microsoft.com/en-us/dotnet/api/system.platformnotsupportedexception?view=netframework-4.7.2
    https://docs.microsoft.com/en-us/dotnet/api/system.badimageformatexception?view=netframework-4.7.2

commit 706442fcecc63ca806d7d42fc760cbebdd74700e
Author: Still Hsu <341464@gmail.com>
Date:   Tue Jun 26 17:09:09 2018 +0800

    Fix styling of several member documentation

    * Fix ' />' caused by Agent Smith oddities
    * Fix styling to be more specific about the mention of IDs

commit 15575dcde00863af09f33bcce134c3f102e52fc3
Author: Still Hsu <341464@gmail.com>
Date:   Tue Jun 26 17:05:52 2018 +0800

    Update CONTRIBUTING.md

    * Add documentation style rule

commit 04c31501e687c57f6c3e72c44bf8f473e8a31cb5
Author: Still Hsu <341464@gmail.com>
Date:   Tue Jun 26 16:51:04 2018 +0800

    Add VSC workspace rule

    * The root workspace limits the ruler to 120 characters for member documentations and excludes folders such as 'samples' and 'docs'.
    * The docs workspace limits the ruler to 70 characters for standard conceptual article to comply with documentation's CONTRIBUTING.md rule, and excludes temprorary folders created by DocFX.

commit 103576d9271c13cf6e82932f7d1d14a128a56167
Author: Still Hsu <341464@gmail.com>
Date:   Sun Jun 24 05:02:25 2018 +0800

    Add XML docs

commit d14372da1d4e3716b4968727fc807024412ea595
Author: Still Hsu <341464@gmail.com>
Date:   Sun Jun 24 05:01:17 2018 +0800

    Add langwordMapping.yml

commit 5c18ecfbc92c605fda519889633164e36aca88d6
Author: Still Hsu <341464@gmail.com>
Date:   Sat Jun 23 11:12:03 2018 +0800

    Bump LastModified to fix UTC DateTime parsing

commit a3cfb6c46452ced1b099cc35ed8deb23981e4f3c
Author: Still Hsu <341464@gmail.com>
Date:   Sat Jun 23 10:49:27 2018 +0800

    Move 'Bundled Preconditions' section

commit 14e7ce8267e30504e1b81d89211929dff04e2090
Author: Still Hsu <341464@gmail.com>
Date:   Sat Jun 23 10:48:42 2018 +0800

    Improve readability for nightlies article

commit 6873fb12acc601521c2f2b6e2800d1538e6950d2
Author: Still Hsu <341464@gmail.com>
Date:   Sat Jun 23 10:47:54 2018 +0800

    Add clarification in the emoji article

    * Emphasize that normal emoji string will not translate to its Unicode representation.
    * Clean up or add some of the samples featured in the article.
    + Add emoji/emote declaration section for clarification.
    + Add WebSocket emote sample.
    - Remove inconsistent styling ('wacky memes' proves to be too out of place).

commit 389885c496d9d0fc7ad0a1946c275449068c0ec0
Author: Still Hsu <341464@gmail.com>
Date:   Sat Jun 23 09:26:18 2018 +0800

    Add cosmetic changes to the master css

    * Alter info box color
    + Add transition to article content

commit e3ec858f11bd8f6e20b8da5a7b9531ba29ffa744
Merge: 9c162389 322d46e4
Author: Still Hsu <341464@gmail.com>
Date:   Sat Jun 23 09:23:51 2018 +0800

    Merge remote-tracking branch 'upstream/dev' into docs/pre-release

commit 322d46e47b47e44f8b62b1ddcdcf39280cac6771
Author: ComputerMaster1st <mr_m.a_thompson@hotmail.co.uk>
Date:   Sat Jun 23 02:20:53 2018 +0100

    Solved 4003 Authentication Error (Race Condition) (#1093)

    * Solved 4003 Authentication Error (Race Condition)

    * Set static interval & removed hello case

commit 9c1623895531a7a7c2ba9120854ac7a7846f56d2
Author: Still Hsu <341464@gmail.com>
Date:   Sat Jun 23 05:50:17 2018 +0800

    Add 'additional information' section for emoji article

commit 51116cd658ee97c906916e70bf3d34ada8f903ab
Author: Still Hsu <341464@gmail.com>
Date:   Sat Jun 23 05:42:50 2018 +0800

    Initial emoji article draft

commit 49a9fb86c754de52c09c517dd0b761de5da989ec
Author: Still Hsu <341464@gmail.com>
Date:   Sat Jun 23 04:12:49 2018 +0800

    Bump DescriptionGenerator to v1.1.0

    + This build adds the functionality of generating managed references' summary into the description tag.

commit a3ae07df55c30c97535fb7dd54a061e2cacc9078
Author: Still Hsu <341464@gmail.com>
Date:   Sat Jun 23 02:16:43 2018 +0800

    Fix typos in Nightlies & Post-execution

commit 4f55bec6dd15e44a9820131b31babff19b9bdda8
Author: Still Hsu <341464@gmail.com>
Date:   Sat Jun 23 02:15:06 2018 +0800

    Add nightly section for clarification

commit 5cc0601a0557a3eb73819d2321d611e8c0b3d135
Author: Still Hsu <341464@gmail.com>
Date:   Wed Jun 20 20:11:14 2018 +0800

    Add DescriptionGenerator plugin

commit 2d43a1dd763392de713914baa28cea8df8378f8c
Author: Still Hsu <341464@gmail.com>
Date:   Tue Jun 19 06:15:36 2018 +0800

    Improve styling

    + Change title font to Noto Sans
    + Add materialized design for commit message box

commit c271b02841c648f41b00868de2729d60d98327f4
Author: Still Hsu <341464@gmail.com>
Date:   Tue Jun 19 04:55:17 2018 +0800

    Cleanup TOC & fix titles

commit 18c0146582f8c118dd96749cefdb9298ce39468b
Merge: dab6ef49 aff4512f
Author: Still Hsu <341464@gmail.com>
Date:   Tue Jun 19 04:32:53 2018 +0800

    Merge branch 'dev' into docs/pre-release

commit aff4512fcd446ce4ec6468c2c8b50e66aa86548d
Author: Builderb <builderbgamer@gmail.com>
Date:   Mon Jun 18 21:02:08 2018 +0100

    Update Discord.Net.Core.csproj (#1081)

commit 033d31294f54945a2b9b2aa17c8d356fcffb4c83
Author: HelpfulStranger999 <helpfulstranger999@gmail.com>
Date:   Mon Jun 18 15:00:40 2018 -0500

    Creates full guild user object, resolves #1047 (#1078)

commit 93878e4a9061253dd8f5874af75057cc71924f0d
Author: HelpfulStranger999 <helpfulstranger999@gmail.com>
Date:   Mon Jun 18 14:57:58 2018 -0500

    Refactors an unused parameter in CommandService#Search (#1025)

commit dab6ef494804d1c2d0084b35c20e10434fb6c8e9
Merge: 47e1ba76 af8a77db
Author: Still Hsu <341464@gmail.com>
Date:   Sun Jun 17 19:50:45 2018 +0800

    Merge pull request #2 from purpledank/docs/faq-n-patches-offline

    + Some contributions from @purpledank

commit af8a77dbc5073474bccf7f5f8ed949c851986e09
Author: Casino Boyale <kayrenhi@gmail.com>
Date:   Sun Jun 17 12:49:21 2018 +0100

    I'm sure you're having as much fun as I am

commit 4f24ea6d1b92bc776b1eb2fa75788538ced15b5b
Author: Casino Boyale <kayrenhi@gmail.com>
Date:   Sun Jun 17 12:44:56 2018 +0100

    Try try try again

commit 47e1ba76cf8ebf978771d6d839a827526457e290
Merge: a17b68c8 48fed064
Author: Still Hsu <341464@gmail.com>
Date:   Sun Jun 17 19:43:06 2018 +0800

    Merge remote-tracking branch 'upstream/dev' into docs/faq-n-patches-offline

commit 034d473209fcf785ed27e39b9a905884e3165e67
Author: Casino Boyale <kayrenhi@gmail.com>
Date:   Sun Jun 17 12:39:13 2018 +0100

    no hablo ingles

commit a17b68c8c0a70b737cfa7c0a01aff411e213608a
Author: Still Hsu <341464@gmail.com>
Date:   Sun Jun 17 19:28:41 2018 +0800

    Proofread and cleanup articles

    * Change passive voice in "Get Started" to active
    * Fix improper preposition in Commands Introduction page
    * Fix minor grammar mistakes in "Your First Bot" (future tense -> present tense/subjunctive mood -> indicative mood/proper noun casing/incorrect noun/add missing article)
    * Fix minor grammar mistakes in "Installation" (missing article)

commit af83007937e3c8639295aa5b188d3784dfe76bab
Author: Still Hsu <341464@gmail.com>
Date:   Sun Jun 17 19:22:06 2018 +0800

    Fix GetCategoryAsync docs

commit 904fd2f20022f96bed2fd646b9ea7a1441ec2ab6
Author: Casino Boyale <kayrenhi@gmail.com>
Date:   Sun Jun 17 12:09:52 2018 +0100

    Changes to last pr

commit 3ea5befc9e1cb025b2eb14ba84c3eda729f21661
Author: Still Hsu <341464@gmail.com>
Date:   Sun Jun 17 18:45:33 2018 +0800

    Cleanup README & Contribution guide

commit 48fed064d446ca4a1c685893320e09b638eace89
Author: NovusTheory <asladich@gmail.com>
Date:   Sat Jun 16 22:34:12 2018 -0500

    Add missing VoiceServerUpdated event (#1089)

commit 532bc744cf0fc15497ed02b532556b3e2bd263c6
Author: Still Hsu <341464@gmail.com>
Date:   Sun Jun 17 08:53:08 2018 +0800

    Bump LastModified plugin

    * Changed the path from 'lastmodified' to 'last-modified' for consistency

commit 532ac136bad629a54fc999ad7f91f764e266c7a4
Author: Still Hsu <341464@gmail.com>
Date:   Sun Jun 17 07:30:12 2018 +0800

    Remove unused bootstrap plugin

commit 081c4cabaaeb729ea5c561be3df662aa0f9c440c
Author: Still Hsu <341464@gmail.com>
Date:   Sun Jun 17 07:03:33 2018 +0800

    Add fixes to partial file & add license

    * Moved theme-switcher code to scripts partial file
    + Add author's MIT license to featherlight javascript

commit e143d7215ec827b59a284e7ac21b4d9e6224a45b
Author: Still Hsu <341464@gmail.com>
Date:   Sun Jun 17 04:43:30 2018 +0800

    Bump post-processor to v1.1.1

commit d0e75c40ddca613809eca7e1147fd4c6b2e9ce7c
Author: Still Hsu <341464@gmail.com>
Date:   Sat Jun 16 06:51:50 2018 +0800

    Fix anchor link

commit adbb66d9d74f00cb39429b4f5c33ffc8f7948b52
Author: Still Hsu <341464@gmail.com>
Date:   Sat Jun 16 06:41:51 2018 +0800

    Rewrite installation page for Core 2.1

commit a93df24a78577a29fb656e50531298f832cd574e
Author: Still Hsu <341464@gmail.com>
Date:   Fri Jun 15 21:21:27 2018 +0800

    Update LastModified to v1.1.0 & add license

commit 45edfaf87d5c3af180171fdd52bbbb2f7cb04c09
Author: Still Hsu <341464@gmail.com>
Date:   Fri Jun 15 19:04:26 2018 +0800

    Add a missing change for 2c7cc738

commit 2c7cc7386a31ff93ed67f04b62a7bd70e140e9ab
Author: Still Hsu <341464@gmail.com>
Date:   Fri Jun 15 19:01:51 2018 +0800

    Replace InvalidPathChars for NS1.3

    * InvalidPathChars does not exist in NS1.3; replaced with GetInvalidPathChars instead.

commit 67eb47332607a3277d2edebb9a04500ad60859c5
Author: Still Hsu <341464@gmail.com>
Date:   Fri Jun 15 19:00:49 2018 +0800

    Cleanup styling of README.md for docs

commit 105182f53a6e913027bb470d47a3b925142cc723
Author: Still Hsu <341464@gmail.com>
Date:   Fri Jun 15 19:00:20 2018 +0800

    Clarify token source

commit 934dc370f5e882c783102e227c8c39f7bc69d8de
Author: Still Hsu <341464@gmail.com>
Date:   Fri Jun 15 18:59:56 2018 +0800

    Move samples to individual folders

commit 94ca53ca3170ac525d9eb0a4f71769ad7dafb452
Author: Still Hsu <341464@gmail.com>
Date:   Fri Jun 15 18:58:57 2018 +0800

    Improve precondition documentation

    + Add precondition usage sample
    + Add precondition group usage sample
    + Move precondition samples to its own sample folder

commit 5269c1bf4c1e8b9fc9d01d9434e6d61b70597374
Author: Still Hsu <341464@gmail.com>
Date:   Fri Jun 15 06:51:48 2018 +0800

    Fix Test to resolve changes made in 15b58e

commit e31e973bf57806c0f259777504bc868bcda41e6a
Author: Still Hsu <341464@gmail.com>
Date:   Fri Jun 15 06:47:12 2018 +0800

    Fix EnterTypingState impl for doc inheritance

commit 15b58edb1911ac3a4b1558fcb0da862076d483b3
Author: Still Hsu <341464@gmail.com>
Date:   Fri Jun 15 06:38:41 2018 +0800

    Remove/cleanup redundant variables

commit 41395ce34cc916ad178e553587081282eaad3d94
Author: Casino Boyale <kayrenhi@gmail.com>
Date:   Wed Jun 13 17:55:57 2018 +0100

    Small amount to see if I'm doing it right

commit ddc3242e71f04b731d82b4f586f29fd29e079424
Author: Still Hsu <341464@gmail.com>
Date:   Tue Jun 5 16:10:35 2018 +0800

    Improve group module example

commit ddfd011b8668770121c5f878c933d075109c644e
Author: Still Hsu <341464@gmail.com>
Date:   Tue Jun 5 11:17:42 2018 +0800

    Fix typos & formatting

commit 9a7e65cf6bd87d7a87652407d10fecbbeff222fb
Author: Still Hsu <341464@gmail.com>
Date:   Tue Jun 5 09:34:31 2018 +0800

    Revise guide paragraphs/samples

    + Fix various formatting.
    + Provide a more detailed walkthrough for dependency injection.
    + Add C# note at intro.

commit 6a8699c4b6556932b500f72aca6181c254fc41dd
Merge: 17a4af71 890904f3
Author: Still Hsu <341464@gmail.com>
Date:   Tue Jun 5 08:24:46 2018 +0800

    Merge remote-tracking branch 'upstream/dev' into docs/faq-n-patches-offline

commit 890904f32cf6c38abea60149b858e2bf8f63154a
Author: NovusTheory <NovusTheory@users.noreply.github.com>
Date:   Thu May 31 16:21:57 2018 -0500

    Allow external VoiceChannel client API implementation (#1057)

    * ConnectAsync(bool external) API implemented

    This allows developers to handle the AudioClient externally (for example with Lavalink)

    * Modify ConnectAsync API and add DisconnectAsync to IAudioChannel

    * Update summary message on IAudioChannel.DisconnectAsync()

    * Review changes:
    - Fix `if (!external)` styling
    - Remove unecessary ConnectAsync overload

    * SocketVoiceChannel overload update

    * Update IAudioChannel.ConnectAsync()
    - Remove ConfigAction from parameters
    - Add SelfDeafen/SelfMute to parameters

    * Remove SocketVoiceChannel.ConnectAsync() default params (Inherit)

commit 17a4af71ee8062966bfe477d4d9ea68b490cfb77
Author: Still Hsu <341464@gmail.com>
Date:   Tue May 29 17:15:10 2018 +0800

    Add documentation for new API version & few events

commit f4fb027ea9cab9ba990a55676d8453bea3e68b1a
Merge: d74c5287 3acf2a9a
Author: Still Hsu <341464@gmail.com>
Date:   Tue May 29 08:25:41 2018 +0800

    Merge remote-tracking branch 'upstream/dev' into docs/faq-n-patches-offline

commit 3acf2a9a6bb13d5b75c09babaf7234cb2707f4e8
Author: HelpfulStranger999 <helpfulstranger999@gmail.com>
Date:   Mon May 28 14:59:30 2018 -0500

    Refactors readMessages, fixing from #1033 (#1075)

commit 513a489bf82ed4e845ff3df9fe21c06e80bb28b8
Author: Christopher F <foxbot@protonmail.com>
Date:   Mon May 28 15:45:42 2018 -0400

    codefix: add VoiceAPIVersion constant to DiscordConfig

commit 9ba38d77966897037cb6355eda2215fd9a235712
Author: Christopher F <foxbot@protonmail.com>
Date:   Mon May 28 15:35:59 2018 -0400

    api: upgrade audio client to VoiceWS v3

commit 64d8938ed5100d4c8f3a2afaec3a6becb53cf9b8
Author: Christopher F <foxbot@protonmail.com>
Date:   Mon May 28 15:25:46 2018 -0400

    fix: Discord does not always send the member on VOICE_STATE_UPDATE

    some guilds aren't on g250k yet? not sure

commit aeb30955932803e88fcd056f817f449e8664715f
Author: FiniteReality <digpoealternate@gmail.com>
Date:   Mon May 28 17:48:38 2018 +0100

    Remove Debug.Print call causing tests to fail

    Forgot to hit save properly... Whoops.

commit a718a7d3c234a37d1c792ac84af0ae8dce61c1a5
Author: Christopher F <foxbot@protonmail.com>
Date:   Mon May 28 12:45:49 2018 -0400

    cleanup: Remove ChannelHelper#IsNsfw

    Closes #1074

    This code was not referenced anywhere in the active codebase.

commit 0c7cb73b06aba3eaeb811b4671fd0f4a5078a491
Author: FiniteReality <digpoealternate@gmail.com>
Date:   Mon May 28 17:41:05 2018 +0100

    Fix permission-related ViewChannel tests

commit 415e2f773978353025ea8b2f6c3d9929601c28c1
Author: FiniteReality <digpoealternate@gmail.com>
Date:   Mon May 28 17:14:18 2018 +0100

    Fix analyzer warnings with tests

    Use (actual, expected) format for Assert.Equal, fixes analyzer warnings

commit b0042606b628e02ffe2bee3135c7ed42c3b8311f
Author: FiniteReality <digpoealternate@gmail.com>
Date:   Mon May 28 17:13:59 2018 +0100

    Move RpcCategoryChannel into the correct project

commit 683b3f2701087db6d49c3a54c6d99c80ef5b2e5a
Author: FiniteReality <digpoealternate@gmail.com>
Date:   Mon May 28 17:12:28 2018 +0100

    Mark ChannelHelper.IsNsfw Obsolete

    Discord no longer treats channels prefixed with 'nsfw' as NSFW,
    so we no longer need to have this check.

commit d74c52873fb13434bca9dd8b56e74104392cb95d
Merge: 341b9588 237ad0f8
Author: Still Hsu <341464@gmail.com>
Date:   Mon May 28 11:48:47 2018 +0800

    Merge branch 'dev' into docs/faq-n-patches-offline

commit 237ad0f8675023478ec8ad41c7b6b6fd19ceed2d
Author: Christopher F <foxbot@protonmail.com>
Date:   Sun May 27 18:00:51 2018 -0400

    Revert "fix: Properly rethrow exceptions in SocketGuild audio client"

    This reverts commit adf4da19fc116759c4246c978143987712fa2116.

    Someone hasn't written c# in a while

commit adf4da19fc116759c4246c978143987712fa2116
Author: Christopher F <foxbot@protonmail.com>
Date:   Sun May 27 17:56:14 2018 -0400

    fix: Properly rethrow exceptions in SocketGuild audio client

commit c0c565fd7ee03fa569027fff7f17db90d9376b4f
Author: Christopher F <foxbot@protonmail.com>
Date:   Sun May 27 16:45:54 2018 -0400

    retain fallback case for if user is still null

commit 8fb2c71814fad9bcab1888fb8d66d693cc98a4b1
Author: Christopher F <foxbot@protonmail.com>
Date:   Sun May 27 16:37:17 2018 -0400

    Add new member objects to events

commit 341b9588d608bcd7460e751b7b0d2cd83bc42e32
Author: Still Hsu <341464@gmail.com>
Date:   Sun May 27 19:01:04 2018 +0800

    Add documentation

commit 2df635e025ef7de2959c232e468f093c103f250f
Merge: 180b20dd 9995cab4
Author: Still Hsu <341464@gmail.com>
Date:   Sun May 27 18:25:51 2018 +0800

    Merge pull request #1 from Chris-Johnston/better-documentation-for-quotation-mark-aliases

    Improve XML docs for commands quotation mark aliases feature

commit 180b20dd02edddfe1d279348516f5d54985eb8f0
Author: Still Hsu <341464@gmail.com>
Date:   Sun May 27 18:19:20 2018 +0800

    Add documentation for new INestedChannel

commit e9f72b6ece60ffe142266b01f90bd5ae8b00c742
Author: Still Hsu <341464@gmail.com>
Date:   Sun May 27 18:18:52 2018 +0800

    Fix missing service provider in example

commit 9995cab40ce542562d87183cff91707bd6f07e60
Merge: a8d3031b 1a146afb
Author: Chris Johnston <chris@thejohnstons.net>
Date:   Sun May 27 01:11:17 2018 -0700

    Merge branch 'docs/faq-n-patches-offline' into better-documentation-for-quotation-mark-aliases

commit a8d3031b2d73bbe813e83bb439345975d1003b55
Author: Chris Johnston <chris@thejohnstons.net>
Date:   Sat May 26 23:32:40 2018 -0700

    Add explanation that if " is removed then it wont work

commit cb7c6d35464bd2d8aa0d5cc0dd20c8a6fa11bb4f
Author: Chris Johnston <chris@thejohnstons.net>
Date:   Sat May 26 23:29:32 2018 -0700

    Add reference to CommandServiceConfig from the util docs'

commit 110b97513fbd26695674190ab217800490e27185
Author: Chris Johnston <chris@thejohnstons.net>
Date:   Sat May 26 23:15:01 2018 -0700

    Add more XML comments to quotation mark alias map stuff, including an example

commit 1a146afbe1f539c210648c39985009bd4ad926b3
Merge: cb57ada8 a06e2126
Author: Still Hsu <341464@gmail.com>
Date:   Sun May 27 11:25:10 2018 +0800

    Merge branch 'dev' into docs/faq-n-patches-offline

commit a06e21261c66e7aeacde11911ce5ee1ed6baba2f
Author: Chris Johnston <chris@thejohnstons.net>
Date:   Sat May 26 11:15:09 2018 -0700

    Fix ChannelPermissions Modify parameter to be correct default value (#1003)

    * fix channel permissions modify parameter to use nullable boolean, correct default value

    * Add general tests for the ChannelPermissions.Modify method to test default values

    * remove unused cast in tests

    * add guildpermission modify no param tests

    * Add no-param modify tests for OverwritePermissions

    * fix inconsistent parameters in GuildPermissions cstr

    * Adjust formatting of methods and cstrs with many parameters

    * remove temp file that was included. no idea what that is

    * Fix System dependency

    I should really stop fixing merge conflicts in the github website.

commit f9cbff5e42c04aa8a0fe87377ba68aa7d748d873
Author: Chris Johnston <chris@thejohnstons.net>
Date:   Sat May 26 11:06:35 2018 -0700

    Fix #995, Move Category Implementation from IGuildChannel to INestedChannel (#1004)

    * Fix #995 ICategoryChannel.CategoryID throws NotSupportedException

    * Add tests

    * change run mode of TestChannelCategories

    * Add throw for GetCategoryAsync

    * Add xml doc explaining why exception is thrown

    * Add test coverage for text and voice channel categories

    * initial implementation of INestedChannel

    * more implementation of INestedChannel design

    * Add case in RestChannel Create for Category type

    * set the CategoryID for RestVoiceChannel

    * rewrite channel category tests to work with existing pattern

    * remove outdated todo

    * Make IVoiceChannel implement INestedChannel

    * remove redundant interface implementation

    * Add c#7 feature from feedback

    * Remove redundant GetCategoryAsync methods from socket entities

    * Added configureawait to async methods

    * change signature of interface GetCategoryAsync

    * Add check for cachemode in rest channel GetCategory

    * remove redundant IGuildChannel interface from ITextChannel and IVoiceChannel

commit 4d8764e124cef12af4b0944d185ec22d9683c520
Author: FiniteReality <digpoealternate@gmail.com>
Date:   Sat May 26 14:11:49 2018 +0100

    Refactor RoleInfo types into separate classes

    - Fixes indentation with a few files (looks like a bad copy+paste job)
    - Renames RoleInfo to RoleEditInfo
    - Moves RoleInfo from MemberRoleAuditLogData into its own class

    All of this should improve docs.

commit cb57ada8d9f4a8a8b787ba6990afb08ea81a89a1
Author: Still Hsu <341464@gmail.com>
Date:   Sat May 26 21:03:07 2018 +0800

    Add partial documentation for audit log objects

commit afda0cd172a98154bc33b4c27eed65580189785d
Author: Still Hsu <341464@gmail.com>
Date:   Sat May 26 20:47:21 2018 +0800

    Add documentation for some REST-based objects

commit 098ead93d98ea9e629f9c4d8681a38ad8c1e9a82
Author: Still Hsu <341464@gmail.com>
Date:   Sat May 26 16:33:38 2018 +0800

    Add partial documentation for audit log impl

commit 5d1621a9c5ea27d8758e6a6e6dc4b4d6c093ff7a
Author: Still Hsu <341464@gmail.com>
Date:   Sat May 26 16:06:20 2018 +0800

    Fix xml docs error

commit 596b47e1b8bbdd349df20da7938eaf4581bccb91
Merge: 3f572ccc fa759a22
Author: Still Hsu <341464@gmail.com>
Date:   Sat May 26 15:54:08 2018 +0800

    Merge branch 'dev' into docs/faq-n-patches-offline

commit 3f572ccc0d10fbdcc514f5ef0701b06c8b75e7ec
Merge: 73ebc025 a9983026
Author: Still Hsu <341464@gmail.com>
Date:   Sat May 26 15:32:38 2018 +0800

    Merge branch 'docs/faq-n-patches-offline' of https://github.com/Still34/Discord.Net into docs/faq-n-patches-offline

commit 73ebc0258031ff74770b1f4b4a8c4be9071f703c
Author: Still Hsu <341464@gmail.com>
Date:   Sat May 26 15:32:23 2018 +0800

    Fix light theme link color

commit fa759a22eac25183eb0fecf6cd0fbbf7f476fa11
Author: Chris Johnston <chris@thejohnstons.net>
Date:   Fri May 25 06:38:59 2018 -0700

    Remove Build Warnings for Obsolete Guild Permission Read Messages (#1067)

    - Replaces the usages of `ReadMessages` with `ViewChannel`
    - Renames the read message parameters of `GuildPermissions#Modify` to be view channel as well

commit bbbac85c46162d7bb44ecdd68194ab79db25037d
Author: Hawx <Hawxy@users.noreply.github.com>
Date:   Fri May 25 20:14:28 2018 +0800

    Update Dependencies and support NS2.0 builds (#1046)

    * Update deps, fix test warnings.

    * Support ns2.0

    * Fix typo

    * Remove ns1.1 support

    * Net.Http and Net.Websockets.Client are not needed in ns2.0

    * Move to net46 per volt

    * Remove ns1.3 constants

commit 5f084adf94f3215b6d68c3a8b61cbfad7376f18c
Author: HelpfulStranger999 <helpfulstranger999@gmail.com>
Date:   Thu May 24 19:17:19 2018 -0500

    Deprecates ReadMessages, introduces ViewChannel (#1033)

    * Deprecates ReadMessages, introduces ViewChannel

    * Adds period and comma somehow missed

commit bc6009ec7207e16aedecdc658dc59b8ac02c400e
Author: Still Hsu <341464@gmail.com>
Date:   Fri May 25 08:08:51 2018 +0800

    Implement IMessageChannel#DeleteMessageAsync (#996)

    * Implement DeleteMessageAsync

    * Refer to MessageHelper instead of duplicating call

    * Fix refactor error

commit cee71ef35a450802ef35090d9eaf167ca39306e8
Author: Chris Johnston <chris@thejohnstons.net>
Date:   Thu May 24 17:07:37 2018 -0700

    Add support for parsing multiple types of quotation marks in commands, Fix #942 (#943)

    * Add ability to support different types of quotation marks

    * Added normal quotation mark to list of aliases, removed single quote mark

    * clean up leftover changes from testing

    * change quotation mark parsing to use a map of matching pairs

    * remove commented out code

    * Fix conventions of the command parser utility functions

    * change storage type of alias dictionary to be IReadOnlyDictionary

    * revert type of CommandServiceConfig QuotationMarkAliasMap to Dictionary

    * minor formatting changes to CommandParser

    * remove unnecessary whitespace

    * Move aliases outside of CommandInfo class

    * copy IReadOnlyDictionary to ImmutableDictionary

    * minor syntax changes in CommandServiceConfig

    * add newline before namespace for consistency

    * newline formatting tweak

    * simplification of GetMatch method for CommandParser

    * add more quote unicode punctuation pairs

    * add check for null value when building ImmutableDictionary

    * Move default alias map into a separate source file

    * Ensure that the collection passed into command service is not null

commit b52af7ae7caaddd79101aeb9f5af2ce482890bc2
Author: Joe4evr <jii.geugten@gmail.com>
Date:   Fri May 25 01:59:32 2018 +0200

    Add a dedicated TimeSpan reader so it doesn't suck (#1005)

    * Add a dedicated TimeSpan reader so it doesn't suck

    * Pass input as lower case

commit c275e575289073fe42ead725de97b97301c7dc50
Author: o Acid Chicken (硫硫▒~E▒▒▒~O) <root@acid-chicken.com>
Date:   Thu May 24 19:52:25 2018 -0400

    Add support casting System.Drawing.Color to Discord.Color

    commit fa3303426766a59e7aa4d67e8b50826cfe7204ec
    Author: Acid Chicken (硫酸鶏) <root@acid-chicken.com>
    Date:   Sun Apr 29 13:50:56 2018 +0900

        Use built-in symbol

        refs: https://github.com/RogueException/Discord.Net/pull/1043#issuecomment-385223999

    commit 27ea82668587960925b73f97c924c9d39ee71f7b
    Author: Acid Chicken (硫酸鶏) <root@acid-chicken.com>
    Date:   Sun Apr 29 11:29:31 2018 +0900

        Add support casting System.Drawing.Color to Discord.Color

    commit 1ab9de24978ff24a018767f80dc95ba19b616988
    Merge: f5bb99c7 a4d1e2bc
    Author: Acid Chicken (硫酸鶏) <root@acid-chicken.com>
    Date:   Sun Apr 29 10:16:46 2018 +0900

        Merge remote-tracking branch 'upstream/dev' into dev

    commit f5bb99c77d0fecec21ad769778d17144c047d8b1
    Merge: 3be8e40d b8b59d97
    Author: Acid Chicken (硫酸鶏) <root@acid-chicken.com>
    Date:   Tue Apr 10 11:07:36 2018 +0900

        Merge remote-tracking branch 'upstream/dev' into dev

    commit 3be8e40d3814fe8455af475b8641ee07a8f368d6
    Merge: c692306f 9d77a3cd
    Author: Acid Chicken (硫酸鶏) <root@acid-chicken.com>
    Date:   Sun Jan 7 15:05:31 2018 +0900

        Merge remote-tracking branch 'upstream/dev' into dev

    commit c692306fcc1e86ab92dd10683d3719f16c02a249
    Author: Acid Chicken (硫酸鶏) <root@acid-chicken.com>
    Date:   Sat Nov 11 10:49:00 2017 +0900

        Add target of the internal fields

    commit 2d08f9a655b4949c1177f778d0f499047484a537
    Author: Acid Chicken (硫酸鶏) <root@acid-chicken.com>
    Date:   Sat Nov 11 10:17:42 2017 +0900

        Add some more extension

    commit 4f19b835ffe8c64a93a9b4659e60b03ac797760f
    Author: Acid Chicken (硫酸鶏) <root@acid-chicken.com>
    Date:   Sat Nov 11 01:19:11 2017 +0900

        Add naming rules

    commit af756cd9feb630baadbf6025cbb079cd9e1f45cb
    Author: Acid Chicken (硫酸鶏) <root@acid-chicken.com>
    Date:   Sat Nov 11 00:35:30 2017 +0900

        Add basic .NET style rules

    commit 503ece558b4f07bd8008157d3aeb6a4e7100d349
    Author: Acid Chicken (硫酸鶏) <root@acid-chicken.com>
    Date:   Fri Nov 10 22:36:52 2017 +0900

        Add EditorConfig

commit 5023357a60bd5ae454b35426ddd279fb3284b7e8
Author: Christopher F <foxbot@protonmail.com>
Date:   Thu May 24 19:36:33 2018 -0400

    codefix #1020: RequestOptions should always be sorted last

commit bf5275e071b78a25fd4501a930e69c5dc8cd3b19
Author: Joe4evr <jii.geugten@gmail.com>
Date:   Thu May 24 19:36:00 2018 -0400

    Add ability to specify parameters on channel creation (#1020)

    commit 07bca5b31a3580d55278878eabb56a82973f8c8f
    Author: Joe4evr <jii.geugten@gmail.com>
    Date:   Fri Apr 6 09:44:50 2018 +0200

        Add ability to specify parameters on channel creation

commit 0ba8b063ad98144232606f422574f9741fd95b7a
Author: HelpfulStranger999 <helpfulstranger999@gmail.com>
Date:   Thu May 24 19:23:44 2018 -0400

    Makes text parameter of sending messages optional (#1042)

    commit 114e5b431b26669bcdaac9f84792a216ad67186f
    Author: HelpfulStranger999 <helpfulstranger999@gmail.com>
    Date:   Sat Apr 28 19:08:35 2018 -0500

        Fixes lack of default value for tts

    commit 1fd8c70c5346ff0c4fdb0093c0fc7fb4b3c8db2c
    Author: HelpfulStranger999 <helpfulstranger999@gmail.com>
    Date:   Sat Apr 28 15:21:11 2018 -0500

        Makes text parameter of sending messages optional

commit 79811d0e618c011e6cca542811031d824650dae5
Author: HelpfulStranger999 <helpfulstranger999@gmail.com>
Date:   Thu May 24 17:35:38 2018 -0500

    Paginate reactions - solved #1007 (#1022)

    * Cleaned up and refactored slightly

    * Resolves #971

    * Adds support for default avatars and resolves #971

    * Amendment

    * Final amendment

    * Paginating reactions

    * Amendments based on feedback

    * Further amendment based on review

    * Final(?) amendment

    * Removes default limit and after user id

    * Removes fromUserId; cleans up model creation; replaces function with individual parameters

commit a9983026f067effeac7108c710ba6917162b7995
Author: Still Hsu <341464@gmail.com>
Date:   Tue May 22 10:15:49 2018 +0800

    Add event docs

    - MessageReceived
    - ChannelUpdated/Destroyed/Created

commit dece19d89505342e5f8c51317b54be8ce69336c9
Merge: fdaa689a e764dafe
Author: Still Hsu <341464@gmail.com>
Date:   Mon May 21 11:47:47 2018 +0800

    Merge branch 'dev' into docs/faq-n-patches-offline

commit e764dafe083bf5db62091ac1f6b3d438eee38882
Author: Quahu <quahuu@gmail.com>
Date:   Sun May 13 15:34:40 2018 +0200

    Add ViewChannel to Voice channel permissions (#1059)

    Previously, Voice channels did not have ViewChannel in their "all" permissions

commit 32fc2df21b1840fd913ccce80c0686e8e853b43d
Author: Alex Gravely <tcbskater@hotmail.com>
Date:   Sat May 12 20:47:44 2018 -0400

    Remove unused field in EmbedFieldBuilder. (#1018)

commit 39dffe858584d0e9eed750bff6426e9562db4262
Author: Finite Reality <FiniteReality@users.noreply.github.com>
Date:   Sun May 13 01:46:07 2018 +0100

    Audit Logs implementation (#1055)

    * Copy audit logs impl from old branch and clean up

    I suck at using git, so I'm gonna use brute force.

    * Remove unnecessary TODOs

    Category channels do not provide any new information, and the other
    I forgot to remove beforehand

    * Add invite update data, clean up after feedback

    * Remove TODOs, add WebhookType enum for future use

    WebhookType is a future-use type, as currently audit logs are the only
    thing which may return it.

commit fdaa689ae8be8e9d2ff5190b6cfed5af244b805b
Author: Still Hsu <341464@gmail.com>
Date:   Wed May 9 06:04:59 2018 +0800

    Add explanation for RunMode

commit ea82c2537e64d4b75f85d9369e90cb55cfcadcc7
Author: Still Hsu <341464@gmail.com>
Date:   Tue May 8 16:30:48 2018 +0800

    Initial proofread of the articles

commit 124f1a267c663fbbb0f2dc23367dd910ae3ba4cc
Merge…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.