This repository has been archived by the owner on Jan 14, 2021. It is now read-only.
Fix the format for converting discords Timestamps to Time #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RX14
reviewed
Oct 18, 2016
| @@ -8,7 +8,7 @@ module Discord | |||
| id: {type: UInt64, converter: SnowflakeConverter}, | |||
| channel_id: {type: UInt64, converter: SnowflakeConverter}, | |||
| author: User, | |||
| timestamp: {type: Time, converter: Time::Format::ISO_8601_DATE}, | |||
| timestamp: {type: Time, converter: Time::Format.new("%FT%T.%L%:z")}, | |||
There was a problem hiding this comment.
This should be extracted into a constant so that it isn't instantiated on every parse.
RX14
suggested changes
Oct 18, 2016
greenbigfrog
force-pushed
the
time-format
branch
from
ebbb30b
to
cb90ab8
Compare
greenbigfrog
force-pushed
the
time-format
branch
from
cb90ab8
to
e95e912
Compare
RX14
approved these changes
Oct 18, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I'm just assuming that discord uses the same formatting for time in the Gateway)