Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag: number-id #80

Merged
merged 7 commits into from May 13, 2022
Merged

Tag: number-id #80

merged 7 commits into from May 13, 2022

Conversation

MrMythicalYT
Copy link
Contributor

A tag showing that Discord IDs must be represented as strings

@almostSouji almostSouji added the 🏷️ tag PR PR ONLY changes tags label Apr 21, 2022
almostSouji
almostSouji requested changes Apr 21, 2022
View reviewed changes
Copy link
Member

@almostSouji almostSouji left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion, but I think this should be added as a point and additional aliases to the "snowflake" tag instead.
(also supported by the keyword overlap in the CI run)

monbrey
monbrey reviewed Apr 21, 2022
View reviewed changes
tags/tags.toml Outdated Show resolved Hide resolved
@MrMythicalYT @monbrey
Update tags/tags.toml
f2ebb18 
Co-authored-by: Ryan Munro <monbrey@gmail.com>
almostSouji
almostSouji requested changes Apr 21, 2022
View reviewed changes
Copy link
Member

@almostSouji almostSouji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe even turn it around so the "do this" comes before the "cannot do this", probably beneficial for selective reading (always name the thing you want people to do before you tell them what not to do)

almostSouji
almostSouji requested changes Apr 22, 2022
View reviewed changes
tags/tags.toml Outdated Show resolved Hide resolved
@MrMythicalYT @almostSouji
Update tags/tags.toml
88bf08a 
Co-authored-by: Souji <timoqueezle@gmail.com>
kyranet
kyranet previously requested changes May 13, 2022
View reviewed changes
tags/tags.toml Outdated Show resolved Hide resolved
@almostSouji @kyranet
fix: should be integer, not number
9adc9d2 
Co-authored-by: A. Román <kyradiscord@gmail.com>
@almostSouji almostSouji merged commit 6026470 into discordjs:main May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@almostSouji almostSouji almostSouji approved these changes

@kyranet kyranet kyranet left review comments

@monbrey monbrey Awaiting requested review from monbrey

Assignees
No one assigned
Labels
🏷️ tag PR PR ONLY changes tags
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MrMythicalYT @monbrey @kyranet @SpaceEEC @almostSouji