Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: external collection package #2934

Merged
merged 12 commits into from Sep 10, 2019

Conversation

@1Computer1
Copy link
Contributor

commented Nov 7, 2018

Please describe the changes this PR makes and why it should be merged:

Use the external collection package over at discordjs/collection.

TODO:

  • Preliminary setup over there
    • CI testing
    • Generate docs
    • Publish
  • Proper name and docs for the extended Collection
  • Modify typings

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.
@appellation

This comment has been minimized.

Copy link
Member

commented Nov 8, 2018

I would recommend publishing the collection package on npm before merging.

@1Computer1

This comment has been minimized.

Copy link
Contributor Author

commented Nov 8, 2018

Yes, that's the plan, I'll add that. Though, the master branch should probably depend on the master branch of collection no?

@appellation

This comment has been minimized.

Copy link
Member

commented Nov 8, 2018

Even though this is an internally controlled package, I think it is still important to specify semver since we can no longer update both modules jointly in case we decide to make breaking changes.

@1Computer1 1Computer1 force-pushed the 1Computer1:external-collection branch from e76d958 to 0ec4495 Feb 17, 2019

1Computer1 added 2 commits Feb 17, 2019
@Gawdl3y

This comment has been minimized.

Copy link
Member

commented Jun 19, 2019

test comment please ignore

1Computer1 added 5 commits Sep 6, 2019

@iCrawl iCrawl changed the title [WIP] Use external collection package feat: external collection package Sep 6, 2019

@iCrawl
iCrawl approved these changes Sep 6, 2019
src/util/Collection.js Outdated Show resolved Hide resolved
iCrawl added 2 commits Sep 8, 2019

@iCrawl iCrawl merged commit dad0cd8 into discordjs:master Sep 10, 2019

3 checks passed

ESLint
Details
TSLint
Details
Documentation
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.