New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typings(GuildCreateChannelOptions): Added missing properties #3052

Merged
merged 2 commits into from Feb 4, 2019

Conversation

Projects
None yet
2 participants
@kyranet
Copy link
Contributor

kyranet commented Feb 4, 2019

Please describe the changes this PR makes and why it should be merged:

Fixes #3050 and more (topic and some semicolons were missing).

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.
@@ -1777,15 +1777,17 @@ declare module 'discord.js' {
type GuildChannelResolvable = Snowflake | GuildChannel;

type GuildCreateChannelOptions = {
type?: 'text' | 'voice' | 'category'
name?: string;

This comment has been minimized.

@SpaceEEC

SpaceEEC Feb 4, 2019

Member

This would allow something like guild.channels.create('name', { name: 'another name' }); which is not valid and could confuse or mislead people.
You could either make a new type GuildChannelCloneOptions or something, or just & { name?: string } the type in the method declaration.

This comment has been minimized.

@kyranet

kyranet Feb 4, 2019

Author Contributor

Done in 0cdbf14 👍

@SpaceEEC SpaceEEC added the t: typings label Feb 4, 2019

@SpaceEEC SpaceEEC merged commit d98d464 into discordjs:master Feb 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kyranet kyranet deleted the kyranet:patch-3 branch Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment