New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typings(ShardClientUtil): Fix `id` property type #3054

Merged
merged 1 commit into from Feb 6, 2019

Conversation

Projects
None yet
2 participants
@kyranet
Copy link
Contributor

kyranet commented Feb 4, 2019

Please describe the changes this PR makes and why it should be merged:

When using internal sharding, ShardClientUtil#id is an array of numbers, otherwise it is a simple number.
Ref:

* @type {number|number[]}

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@SpaceEEC SpaceEEC added the t: typings label Feb 5, 2019

@SpaceEEC SpaceEEC merged commit ae72690 into discordjs:master Feb 6, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Koyamie added a commit to Koyamie/discord.js that referenced this pull request Feb 6, 2019

Merge pull request #18 from discordjs/master
typings(ShardClientUtil): fix `id` property type (discordjs#3054)

@kyranet kyranet deleted the kyranet:patch-3 branch Feb 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment