New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GuildMember): add explicit channel resolve error to member edit #3059

Merged
merged 1 commit into from Feb 12, 2019

Conversation

Projects
None yet
1 participant
@SpaceEEC
Copy link
Member

SpaceEEC commented Feb 6, 2019

Please describe the changes this PR makes and why it should be merged:

This PR backports #2958 to the 11.4-dev branch throwing an explicit/better error when passing bad input to GuildMember#setVoiceChannel or its GuildMember#edit variant.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@SpaceEEC SpaceEEC merged commit a0ff72b into discordjs:11.4-dev Feb 12, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@SpaceEEC SpaceEEC deleted the SpaceEEC:fix/guild_member_edit branch Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment