New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Util): splitMessage throws an error if a chunk is too large #3060

Merged
merged 1 commit into from Feb 12, 2019

Conversation

Projects
None yet
1 participant
@SpaceEEC
Copy link
Member

SpaceEEC commented Feb 6, 2019

Please describe the changes this PR makes and why it should be merged:

This PR backports #2936 to the 11.4-dev branch making Util.splitMessage throw an error when any chunk, not just the first, exceeds the max length.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@SpaceEEC SpaceEEC merged commit 1618829 into discordjs:11.4-dev Feb 12, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@SpaceEEC SpaceEEC deleted the SpaceEEC:fix/util_split_message branch Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment