Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: Add missing events in constants #3124

Merged
merged 2 commits into from Mar 5, 2019

Conversation

Projects
None yet
2 participants
@kyranet
Copy link
Contributor

kyranet commented Mar 3, 2019

Please describe the changes this PR makes and why it should be merged:

And added VOICE_SERVER_UPDATE to constants.Events. Though unused inside discord.js, it's still a valid name outside it, and may be used in the future if we expose this event outside raw.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

kyranet added some commits Mar 3, 2019

@SpaceEEC SpaceEEC added the t: typings label Mar 4, 2019

@SpaceEEC SpaceEEC added the t: utility label Mar 5, 2019

@SpaceEEC SpaceEEC merged commit 1327889 into discordjs:master Mar 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kyranet kyranet deleted the kyranet:constants-missing-events branch Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.