Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: Fix missing defaultRole property under Guild in typings. #3126

Merged
merged 2 commits into from Mar 4, 2019

Conversation

Projects
None yet
3 participants
@KamranMackey
Copy link
Contributor

KamranMackey commented Mar 4, 2019

I don't know how this wasn't already there, but I added the missing defaultRole property to the typings. Did this because I found this issue myself when needing to use it and realized that it wasn't already in the typings file.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.
[typings] Fix missing defaultRole property under Guild.
Signed-off-by: Kamran Mackey <kamranm1200@gmail.com>
@@ -386,6 +386,7 @@ declare module 'discord.js' {
public readonly createdAt: Date;
public readonly createdTimestamp: number;
public defaultMessageNotifications: DefaultMessageNotifications | number;
public defaultRole: Role;

This comment was marked as resolved.

@appellation

appellation Mar 4, 2019

Member

This is readonly

[typings] Added missing readonly identifier.
Signed-off-by: Kamran Mackey <kamranm1200@gmail.com>

@SpaceEEC SpaceEEC added the t: typings label Mar 4, 2019

@SpaceEEC SpaceEEC merged commit 1207c24 into discordjs:master Mar 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.