Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Presence): add missing descriptions to clientStatus #3127

Merged
merged 5 commits into from Apr 14, 2019

Conversation

Projects
None yet
3 participants
@izexi
Copy link
Contributor

commented Mar 4, 2019

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.
@vladfrangu
Copy link
Contributor

left a comment

Small NITs, also corrects the typedef, since each of them can be undefined

Show resolved Hide resolved src/structures/Presence.js Outdated
Show resolved Hide resolved src/structures/Presence.js Outdated
Show resolved Hide resolved src/structures/Presence.js Outdated

vladfrangu and others added some commits Apr 14, 2019

Update src/structures/Presence.js
Co-Authored-By: izexi <43889168+izexi@users.noreply.github.com>
Update src/structures/Presence.js
Co-Authored-By: izexi <43889168+izexi@users.noreply.github.com>
Update src/structures/Presence.js
Co-Authored-By: izexi <43889168+izexi@users.noreply.github.com>
@vladfrangu

This comment has been minimized.

Copy link
Contributor

commented Apr 14, 2019

Can you also update typings to reflect this PR?

Already done

@izexi izexi changed the title docs: add missing descriptions to User.clientStatus docs(Presence): add missing descriptions to clientStatus Apr 14, 2019

@SpaceEEC SpaceEEC merged commit 5d10585 into discordjs:master Apr 14, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@izexi izexi deleted the izexi:client-status-docs-description branch Apr 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.