Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed code and documentation for Guild.fetchAuditLogs "after" option #3142

Merged
merged 2 commits into from Mar 12, 2019

Conversation

Projects
None yet
2 participants
@Monbrey
Copy link
Contributor

Monbrey commented Mar 11, 2019

Please describe the changes this PR makes and why it should be merged:
fixes #3141
Removes the code and JSDoc for options.after in Guild.fetchAuditLogs() as this parameter is not supported by the API.
Reference: https://discordapp.com/developers/docs/resources/audit-log#get-guild-audit-log-query-string-parameters

I tested the code - Guild.fetchAuditLogs() still works, and if anyone passes an options.after parameter it still does exactly what it did before: nothing. Therefore I consider this a non-breaking change.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@SpaceEEC SpaceEEC merged commit df1889a into discordjs:master Mar 12, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Koyamie added a commit to Koyamie/discord.js that referenced this pull request Mar 12, 2019

Merge pull request #34 from discordjs/master
cleanup(Guild): removed fetchAuditLogs' "after" option (discordjs#3142)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.